[jira] [Commented] (FLINK-9332) Fix Codegen error of CallGenerator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471501#comment-16471501 ] 

ASF GitHub Bot commented on FLINK-9332:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/5988

    [FLINK-9332][TableAPI & SQL] Fix Codegen error of CallGenerator

    
    
    ## What is the purpose of the change
    
    Fix bugs that nullTerm do not handle function call return value correctly.
    
    
    ## Brief change log
    - check function call return value and reset nullTerm if necessary.
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    org.apache.flink.table.runtime.stream.sql.SqlITCase#testNullableFunctionCall
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency):  no
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
      - The serializers:  no
      - The runtime per-record code paths (performance sensitive):  no
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector:  no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no
      - If yes, how is the feature documented? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-9332

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5988.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5988
    
----
commit 6feff0619846d3fb04b10566cb532b9ce5329128
Author: Xpray <le...@...>
Date:   2018-05-11T05:06:31Z

    [FLINK-9332][TableAPI & SQL] Fix Codegen error of CallGenerator

----


> Fix Codegen error of CallGenerator  
> ------------------------------------
>
>                 Key: FLINK-9332
>                 URL: https://issues.apache.org/jira/browse/FLINK-9332
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>            Priority: Major
>
> function call may return null, but nullTerm did not handle it correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)