[jira] [Commented] (PIO-56) Unit tests in module core should not require real setup

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIO-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053365#comment-16053365 ] 

ASF GitHub Bot commented on PIO-56:
-----------------------------------

Github user lucasbm88 commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/355
  
    Since elasticsearch 1.x should be removed in the near future I updated this PR with a new implementation that uses in-memory H2 (MYSQL mode) to run unit tests. With this code developers can run unit tests on projects core and data without needing to manually setup a metadata or eventdata server.
    @dszeto and  @marevol could you review please?
    
    To validate:
     - Clone Prediction-io in a fresh environment
     - Run <pio_src_root>/make-distribution.sh in order to install local pio dependencies.
     - Run <pio_src_root>/sbt core/test
     - Run <pio_src_root>/sbt data/test
    
    None tests should fail. 
    
    Thx


> Unit tests in module core should not require real setup
> -------------------------------------------------------
>
>                 Key: PIO-56
>                 URL: https://issues.apache.org/jira/browse/PIO-56
>             Project: PredictionIO
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.10.0-incubating
>         Environment: Tested with Mac OS X, i7, 8GB
>            Reporter: Lucas Bonatto Miguel
>              Labels: development_environment
>
> *This issue affects only developers*
> When downloading the code from github and trying to run the tests of the project core via sbt, one will face an error stating that the METADATA configuration is missing, e.g:
> [ERROR] [Storage$] Required repository (METADATA) configuration is missing.
> [ERROR] [Storage$] There were 1 configuration errors. Exiting.
> It looks like the project predictionio core requires a METADATA datasource (elasticsearch) installed and configured in the developer machine.
> There are some benefits if the project require less external installation/configuration:
>  - Developers would have an easy setup of the environment.
>  - Continuous integration would be easier
> How to reproduce:
>  - Download predictionio from github
>  - In root folder run ./make-distribution.sh
>  - In root folder run sbt core/test



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)