[jira] [Commented] (KAFKA-1008) Unmap before resizing

["Jun Rao (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13765579#comment-13765579 ] 

Jun Rao commented on KAFKA-1008:
--------------------------------

Thanks for the patch. Reviewed patch v7 for 0.8. Looks good overall. Just a couple of minor comments.

70. OffsetIndex: Should forceUnmap() be private?

71. Just a question. Does anyone know if the OS property shows up as windows on cygwin?

Sriram,

For 1.1, the purpose is probably to save the division calculation, which is a bit expensive.
                
> Unmap before resizing
> ---------------------
>
>                 Key: KAFKA-1008
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1008
>             Project: Kafka
>          Issue Type: Bug
>          Components: core, log
>    Affects Versions: 0.8
>         Environment: Windows, Linux, Mac OS
>            Reporter: Elizabeth Wei
>            Assignee: Jay Kreps
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: KAFKA-0.8-1008-v7.patch, KAFKA-1008-v6.patch, KAFKA-trunk-1008-v7.patch, unmap-v5.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this problem.
> Following Jay's advice, I made a helper method called tryUnmap(). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira