You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by gi...@git.apache.org on 2017/06/27 18:48:21 UTC

[GitHub] rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx

rabbah commented on a change in pull request #2427: Support client certificate on cli and nginx
URL: https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r124362806
 
 

 ##########
 File path: ansible/roles/nginx/files/openwhisk-client-ca-key.pem
 ##########
 @@ -0,0 +1,27 @@
+-----BEGIN RSA PRIVATE KEY-----
 
 Review comment:
   should we perhaps generate these as part of the setup rather that store them.
   i know it's convenient and it does take a few seconds to get a key.
   since i generated the previous keys, i'm also asking myself if that was the right thing to do and we should avoid that. that way you can see what values are used for the key, and can change them.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services