You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/20 22:31:54 UTC

[GitHub] [pulsar] sijie opened a new pull request #6101: [Functions] The argument and description for dead letter topic is wrong

sijie opened a new pull request #6101: [Functions] The argument and description for dead letter topic is wrong
URL: https://github.com/apache/pulsar/pull/6101
 
 
   *Motivation*
   
    #5400 introduces `customRuntimeOptions` in function details. But the description was wrong. The mistake was probably introduced by bad merges.
   
   *Modification*
   
   Fix the argument and description for `deadletterTopic` and `customRuntimeOptions`.
   
   *Tests*
   
   Add a unit test to ensure the parameters are set correctly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] codelipenghui merged pull request #6101: [Functions] The argument and description for dead letter topic is wrong

Posted by GitBox <gi...@apache.org>.

codelipenghui merged pull request #6101: [Functions] The argument and description for dead letter topic is wrong
URL: https://github.com/apache/pulsar/pull/6101
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on issue #6101: [Functions] The argument and description for dead letter topic is wrong

Posted by GitBox <gi...@apache.org>.

sijie commented on issue #6101: [Functions] The argument and description for dead letter topic is wrong
URL: https://github.com/apache/pulsar/pull/6101#issuecomment-576450209
 
 
   run java8 tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services