[jira] [Commented] (STORM-232) ship JNI dependencies with the storm jar

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987756#comment-13987756 ] 

ASF GitHub Bot commented on STORM-232:
--------------------------------------

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/28#discussion_r12232227
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -438,6 +438,13 @@
           (FileUtils/moveDirectory (File. tmproot) (File. stormroot))
           ))
     
    +(defn jlp [stormroot conf]
    +  (let [resource-root (str stormroot "/" RESOURCES-SUBDIR)
    +        os (clojure.string/replace (System/getProperty "os.name") #"\s+" "_")
    +        arch (System/getProperty "os.arch")
    +        arch-resource-root (str resource-root "/" os "-" arch)]
    +    (str arch-resource-root ":" resource-root ":" (conf JAVA-LIBRARY-PATH)))) 
    --- End diff --
    
    Would this fail on Windows because of the `/`?


> ship JNI dependencies with the storm jar
> ----------------------------------------
>
>                 Key: STORM-232
>                 URL: https://issues.apache.org/jira/browse/STORM-232
>             Project: Apache Storm (Incubating)
>          Issue Type: Sub-task
>            Reporter: Robert Joseph Evans
>
> In a multi-tenant environment we need a way for users to include their JNI dependencies in the storm topology jar itself.  This mostly involves a convention on how to package the dependencies, and proper environment/command line setup when launching the worker process.



--
This message was sent by Atlassian JIRA
(v6.2#6252)