You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2018/01/08 18:14:48 UTC

Review Request 65023: Added `state::read` to complement `state::checkpoint`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65023/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-8375
    https://issues.apache.org/jira/browse/MESOS-8375


Repository: mesos


Description
-------

Added `state::read` to complement `state::checkpoint`.


Diffs
-----

  src/slave/state.hpp 01abb5095cf09dd36d7f154d007336892bd8df46 


Diff: https://reviews.apache.org/r/65023/diff/1/


Testing
-------


Thanks,

Michael Park

Re: Review Request 65023: Added `state::read` to complement `state::checkpoint`.

Posted by Benjamin Mahler <bm...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65023/#review195099
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/state.hpp
Lines 78 (patched)
<https://reviews.apache.org/r/65023/#comment274244>

    extra a



src/slave/state.hpp
Lines 84-86 (patched)
<https://reviews.apache.org/r/65023/#comment274245>

    Early return on error?


- Benjamin Mahler


On Jan. 8, 2018, 6:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65023/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2018, 6:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8375
>     https://issues.apache.org/jira/browse/MESOS-8375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added `state::read` to complement `state::checkpoint`.
> 
> 
> Diffs
> -----
> 
>   src/slave/state.hpp 01abb5095cf09dd36d7f154d007336892bd8df46 
> 
> 
> Diff: https://reviews.apache.org/r/65023/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>