You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/06 12:25:07 UTC

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #1869: [Minor] Clean up DecimalArray API Usage

liukun4515 commented on pull request #1869:
URL: https://github.com/apache/arrow-datafusion/pull/1869#issuecomment-1059953379


   > ~Draft as it builds on #1851~
   > 
   > # Which issue does this PR close?
   > N/A
   > 
   > # Rationale for this change
   > Use a faster (less bounds checking) and more idiomatic API for creating `DecimalArray` mostly so that when others are looking for examples of how to create `DecimalArray`s they find one of these rather than `DecimalBuilder`
   > 
   > # What changes are included in this PR?
   > Cleans up some `DecimalArray` creation using APIs added in [apache/arrow-rs#1223](https://github.com/apache/arrow-rs/pull/1223)
   > 
   > I didn't spend any time cleaning up binary.rs as I believe @liukun4515 has plans for that
   > 
   > # Are there any user-facing changes?
   
   Thanks for your refactor. @alamb 
   I will go through the codebase and find any place needed to clean up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org