You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Jan Høydahl <ja...@cominvent.com> on 2019/10/10 21:11:03 UTC
GitBox emails in issues@ list
GitBox emails on the issues@ list are not threaded per PullRequest.
It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
[GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
Anyone know if it is possible?
--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: GitBox emails in issues@ list
Posted by Jan Høydahl <ja...@cominvent.com>.
I just opened https://issues.apache.org/jira/browse/INFRA-19263
--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com
> 13. okt. 2019 kl. 02:38 skrev Jan Høydahl <ja...@cominvent.com>:
>
> Hi
>
> GitBox is an Apache service run by Infra, those emails don't come from GitHub directly.
>
> I see that the mails coming from JIRA to issues@ list has those References and In-Reply-To headers and they thread well.
> But emails from GitBox only contain Message-Id, like this
>
> Message-ID: <157090365380.23328.18366539867310816446.gitbox@gitbox.apache.org <ma...@gitbox.apache.org>>
>
> The script that receives Webhook callbacks from GitHub seems to be this one
> https://github.com/apache/infrastructure-puppet/blob/deployment/modules/gitbox/files/cgi-bin/issues.cgi <https://github.com/apache/infrastructure-puppet/blob/deployment/modules/gitbox/files/cgi-bin/issues.cgi>
>
> So I guess it should not be too hard to extend this script with a capability to generate a stable well-defined Message-Id on all "…opened a new PR", and then generate References and In-Reply-To headers for subsequent actions on the same PR.
>
> Anyone want to attempt a PR for Infra? :)
> There's already a similar JIRA INFRA-18350 suggesting a shorter subject, but we should probably create a new JIRA for the threading.
>
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com <http://www.cominvent.com/>
>
>> 11. okt. 2019 kl. 23:16 skrev Michael Sokolov <msokolov@gmail.com <ma...@gmail.com>>:
>>
>> https://developers.google.com/gmail/api/guides/threads <https://developers.google.com/gmail/api/guides/threads> explains the
>> threading criteria, at least for its APIs. It says:
>>
>> The References and In-Reply-To headers must be set in compliance with
>> the RFC 2822 standard.
>>
>> The Subject headers must match.
>>
>> so clearly the Subject matters. Probably it can handle Re: prefixes?
>>
>> https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications <https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications>
>> doesn't say much about being able to configure Subjects though
>>
>> On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <jp...@gmail.com> wrote:
>>>
>>> I don't know if that is possible, but I would appreciate threaded
>>> responses much better too!
>>>
>>> On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <ja...@cominvent.com> wrote:
>>>>
>>>> GitBox emails on the issues@ list are not threaded per PullRequest.
>>>> It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
>>>> I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
>>>>
>>>> [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
>>>>
>>>> Anyone know if it is possible?
>>>>
>>>> --
>>>> Jan Høydahl, search solution architect
>>>> Cominvent AS - www.cominvent.com
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>>
>>>
>>>
>>> --
>>> Adrien
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
Re: GitBox emails in issues@ list
Posted by Jan Høydahl <ja...@cominvent.com>.
Hi
GitBox is an Apache service run by Infra, those emails don't come from GitHub directly.
I see that the mails coming from JIRA to issues@ list has those References and In-Reply-To headers and they thread well.
But emails from GitBox only contain Message-Id, like this
Message-ID: <15...@gitbox.apache.org>
The script that receives Webhook callbacks from GitHub seems to be this one
https://github.com/apache/infrastructure-puppet/blob/deployment/modules/gitbox/files/cgi-bin/issues.cgi
So I guess it should not be too hard to extend this script with a capability to generate a stable well-defined Message-Id on all "…opened a new PR", and then generate References and In-Reply-To headers for subsequent actions on the same PR.
Anyone want to attempt a PR for Infra? :)
There's already a similar JIRA INFRA-18350 suggesting a shorter subject, but we should probably create a new JIRA for the threading.
--
Jan Høydahl, search solution architect
Cominvent AS - www.cominvent.com
> 11. okt. 2019 kl. 23:16 skrev Michael Sokolov <ms...@gmail.com>:
>
> https://developers.google.com/gmail/api/guides/threads explains the
> threading criteria, at least for its APIs. It says:
>
> The References and In-Reply-To headers must be set in compliance with
> the RFC 2822 standard.
>
> The Subject headers must match.
>
> so clearly the Subject matters. Probably it can handle Re: prefixes?
>
> https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications
> doesn't say much about being able to configure Subjects though
>
> On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <jp...@gmail.com> wrote:
>>
>> I don't know if that is possible, but I would appreciate threaded
>> responses much better too!
>>
>> On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <ja...@cominvent.com> wrote:
>>>
>>> GitBox emails on the issues@ list are not threaded per PullRequest.
>>> It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
>>> I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
>>>
>>> [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
>>>
>>> Anyone know if it is possible?
>>>
>>> --
>>> Jan Høydahl, search solution architect
>>> Cominvent AS - www.cominvent.com
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>
>>
>> --
>> Adrien
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
Re: GitBox emails in issues@ list
Posted by Michael Sokolov <ms...@gmail.com>.
https://developers.google.com/gmail/api/guides/threads explains the
threading criteria, at least for its APIs. It says:
The References and In-Reply-To headers must be set in compliance with
the RFC 2822 standard.
The Subject headers must match.
so clearly the Subject matters. Probably it can handle Re: prefixes?
https://help.github.com/en/enterprise/2.18/user/articles/about-email-notifications
doesn't say much about being able to configure Subjects though
On Fri, Oct 11, 2019 at 10:40 AM Adrien Grand <jp...@gmail.com> wrote:
>
> I don't know if that is possible, but I would appreciate threaded
> responses much better too!
>
> On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <ja...@cominvent.com> wrote:
> >
> > GitBox emails on the issues@ list are not threaded per PullRequest.
> > It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
> > I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
> >
> > [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
> >
> > Anyone know if it is possible?
> >
> > --
> > Jan Høydahl, search solution architect
> > Cominvent AS - www.cominvent.com
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> > For additional commands, e-mail: dev-help@lucene.apache.org
> >
>
>
> --
> Adrien
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
Re: GitBox emails in issues@ list
Posted by Adrien Grand <jp...@gmail.com>.
I don't know if that is possible, but I would appreciate threaded
responses much better too!
On Thu, Oct 10, 2019 at 11:11 PM Jan Høydahl <ja...@cominvent.com> wrote:
>
> GitBox emails on the issues@ list are not threaded per PullRequest.
> It would be very beneficial if all GitBox mails for the same PR# be grouped in same thread for easier consumption.
> I guess that would mean they have identical Email Subject, instead of today when the Subject varies per comment:
>
> [GitHub] [lucene-solr] chatman commented on a change in pull request #929: SOLR-13821: Package Store for storing package artefacts
>
> Anyone know if it is possible?
>
> --
> Jan Høydahl, search solution architect
> Cominvent AS - www.cominvent.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
--
Adrien
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org