You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2015/06/23 20:15:27 UTC
[VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Hey Guys,
We had some discussion over mail and in KIP hangout. I will update the RB
with proposed changes.
On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com> wrote:
> Hi Neha,
>
> Answers inline.
>
> On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io> wrote:
>
>> Thanks for submitting the KIP, Ashish! Few questions.
>>
>> 1. Can you specify more details around how you expect csv output to be
>> used. Same for json.
>>
> CSV takes less storage space and is more convenient for shell operations.
> A simple diff between two csv outputs would tell you if something changed
> or not. It's also common in certain industries when dealing with legacy
> systems and workflows. Try importing JSON into MS Excel.
>
> JSON on the other hand has easy interpretation, compact notation and
> supports Hierarchical Data. If someone is planning to run the tool
> periodically and send the output to some server or even just persist it
> somewhere, JSON is probably the way to go.
>
> 2. If we add these options, would you still need the old format. If
>> csv/json offers more convenience, should we have a plan to phase out the
>> old format?
>>
> Probably not, but having it around will not hurt. Having three output
> formats is not that bad and I do not expect this list to grow in future.
>
>>
>> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
>> wrote:
>>
>> > Jun,
>> >
>> > Can we add this as part of next KIP's agenda?
>> >
>> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
>> > wrote:
>> >
>> > > Maybe bring it up at the next KIP call, to make sure everyone is
>> aware?
>> > >
>> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
>> > wrote:
>> > > > Hi Guys,
>> > > >
>> > > > This has been lying around for quite some time. Should I start a
>> voting
>> > > > thread on this?
>> > > >
>> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <as...@cloudera.com>
>> > > wrote:
>> > > >
>> > > >> Had to change the title of the page and that surprisingly changed
>> the
>> > > link
>> > > >> as well. KIP-23 is now available at here
>> > > >> <
>> > >
>> >
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
>> >
>> > > >> .
>> > > >>
>> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <asingh@cloudera.com
>> >
>> > > wrote:
>> > > >>
>> > > >>> Hi Guys,
>> > > >>>
>> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
>> options
>> > to
>> > > >>> ConsumerGroupCommand
>> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
>> > > KAFKA-313
>> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
>> made
>> > as
>> > > >>> part of the JIRA can be found here <
>> > > https://reviews.apache.org/r/28096/>.
>> > > >>>
>> > > >>> Comments and suggestions are welcome!
>> > > >>>
>> > > >>> --
>> > > >>>
>> > > >>> Regards,
>> > > >>> Ashish
>> > > >>>
>> > > >>
>> > > >>
>> > > >>
>> > > >> --
>> > > >>
>> > > >> Regards,
>> > > >> Ashish
>> > > >>
>> > > >
>> > > >
>> > > >
>> > > > --
>> > > >
>> > > > Regards,
>> > > > Ashish
>> > >
>> >
>> >
>> >
>> > --
>> >
>> > Regards,
>> > Ashish
>> >
>>
>>
>>
>> --
>> Thanks,
>> Neha
>>
>
>
>
> --
>
> Regards,
> Ashish
>
--
Regards,
Ashish
Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Posted by Ashish Singh <as...@cloudera.com>.
Thanks for your comments and vote guys. KIP-23 passed retroactively with 2
binding +1s and 2 non-binding +1s.
On Mon, Jun 29, 2015 at 3:25 PM, Jun Rao <ju...@confluent.io> wrote:
> +1
>
> Thanks,
>
> Jun
>
> On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
>> Hey Guys,
>>
>> We had some discussion over mail and in KIP hangout. I will update the RB
>> with proposed changes.
>>
>>
>> On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
>> wrote:
>>
>>> Hi Neha,
>>>
>>> Answers inline.
>>>
>>> On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
>>> wrote:
>>>
>>>> Thanks for submitting the KIP, Ashish! Few questions.
>>>>
>>>> 1. Can you specify more details around how you expect csv output to be
>>>> used. Same for json.
>>>>
>>> CSV takes less storage space and is more convenient for shell
>>> operations. A simple diff between two csv outputs would tell you if
>>> something changed or not. It's also common in certain industries when
>>> dealing with legacy systems and workflows. Try importing JSON into MS Excel.
>>>
>>> JSON on the other hand has easy interpretation, compact notation and
>>> supports Hierarchical Data. If someone is planning to run the tool
>>> periodically and send the output to some server or even just persist it
>>> somewhere, JSON is probably the way to go.
>>>
>>> 2. If we add these options, would you still need the old format. If
>>>> csv/json offers more convenience, should we have a plan to phase out the
>>>> old format?
>>>>
>>> Probably not, but having it around will not hurt. Having three output
>>> formats is not that bad and I do not expect this list to grow in future.
>>>
>>>>
>>>> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
>>>> wrote:
>>>>
>>>> > Jun,
>>>> >
>>>> > Can we add this as part of next KIP's agenda?
>>>> >
>>>> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
>>>> > wrote:
>>>> >
>>>> > > Maybe bring it up at the next KIP call, to make sure everyone is
>>>> aware?
>>>> > >
>>>> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
>>>> > wrote:
>>>> > > > Hi Guys,
>>>> > > >
>>>> > > > This has been lying around for quite some time. Should I start a
>>>> voting
>>>> > > > thread on this?
>>>> > > >
>>>> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
>>>> asingh@cloudera.com>
>>>> > > wrote:
>>>> > > >
>>>> > > >> Had to change the title of the page and that surprisingly
>>>> changed the
>>>> > > link
>>>> > > >> as well. KIP-23 is now available at here
>>>> > > >> <
>>>> > >
>>>> >
>>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
>>>> >
>>>> > > >> .
>>>> > > >>
>>>> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
>>>> asingh@cloudera.com>
>>>> > > wrote:
>>>> > > >>
>>>> > > >>> Hi Guys,
>>>> > > >>>
>>>> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
>>>> options
>>>> > to
>>>> > > >>> ConsumerGroupCommand
>>>> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
>>>> > > KAFKA-313
>>>> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
>>>> made
>>>> > as
>>>> > > >>> part of the JIRA can be found here <
>>>> > > https://reviews.apache.org/r/28096/>.
>>>> > > >>>
>>>> > > >>> Comments and suggestions are welcome!
>>>> > > >>>
>>>> > > >>> --
>>>> > > >>>
>>>> > > >>> Regards,
>>>> > > >>> Ashish
>>>> > > >>>
>>>> > > >>
>>>> > > >>
>>>> > > >>
>>>> > > >> --
>>>> > > >>
>>>> > > >> Regards,
>>>> > > >> Ashish
>>>> > > >>
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > --
>>>> > > >
>>>> > > > Regards,
>>>> > > > Ashish
>>>> > >
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> >
>>>> > Regards,
>>>> > Ashish
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>> Thanks,
>>>> Neha
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Regards,
>>> Ashish
>>>
>>
>>
>>
>> --
>>
>> Regards,
>> Ashish
>>
>
>
--
Regards,
Ashish
Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Posted by Jun Rao <ju...@confluent.io>.
+1
Thanks,
Jun
On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com> wrote:
> Hey Guys,
>
> We had some discussion over mail and in KIP hangout. I will update the RB
> with proposed changes.
>
>
> On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
>> Hi Neha,
>>
>> Answers inline.
>>
>> On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io> wrote:
>>
>>> Thanks for submitting the KIP, Ashish! Few questions.
>>>
>>> 1. Can you specify more details around how you expect csv output to be
>>> used. Same for json.
>>>
>> CSV takes less storage space and is more convenient for shell operations.
>> A simple diff between two csv outputs would tell you if something changed
>> or not. It's also common in certain industries when dealing with legacy
>> systems and workflows. Try importing JSON into MS Excel.
>>
>> JSON on the other hand has easy interpretation, compact notation and
>> supports Hierarchical Data. If someone is planning to run the tool
>> periodically and send the output to some server or even just persist it
>> somewhere, JSON is probably the way to go.
>>
>> 2. If we add these options, would you still need the old format. If
>>> csv/json offers more convenience, should we have a plan to phase out the
>>> old format?
>>>
>> Probably not, but having it around will not hurt. Having three output
>> formats is not that bad and I do not expect this list to grow in future.
>>
>>>
>>> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
>>> wrote:
>>>
>>> > Jun,
>>> >
>>> > Can we add this as part of next KIP's agenda?
>>> >
>>> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
>>> > wrote:
>>> >
>>> > > Maybe bring it up at the next KIP call, to make sure everyone is
>>> aware?
>>> > >
>>> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
>>> > wrote:
>>> > > > Hi Guys,
>>> > > >
>>> > > > This has been lying around for quite some time. Should I start a
>>> voting
>>> > > > thread on this?
>>> > > >
>>> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <asingh@cloudera.com
>>> >
>>> > > wrote:
>>> > > >
>>> > > >> Had to change the title of the page and that surprisingly changed
>>> the
>>> > > link
>>> > > >> as well. KIP-23 is now available at here
>>> > > >> <
>>> > >
>>> >
>>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
>>> >
>>> > > >> .
>>> > > >>
>>> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
>>> asingh@cloudera.com>
>>> > > wrote:
>>> > > >>
>>> > > >>> Hi Guys,
>>> > > >>>
>>> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
>>> options
>>> > to
>>> > > >>> ConsumerGroupCommand
>>> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
>>> > > KAFKA-313
>>> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
>>> made
>>> > as
>>> > > >>> part of the JIRA can be found here <
>>> > > https://reviews.apache.org/r/28096/>.
>>> > > >>>
>>> > > >>> Comments and suggestions are welcome!
>>> > > >>>
>>> > > >>> --
>>> > > >>>
>>> > > >>> Regards,
>>> > > >>> Ashish
>>> > > >>>
>>> > > >>
>>> > > >>
>>> > > >>
>>> > > >> --
>>> > > >>
>>> > > >> Regards,
>>> > > >> Ashish
>>> > > >>
>>> > > >
>>> > > >
>>> > > >
>>> > > > --
>>> > > >
>>> > > > Regards,
>>> > > > Ashish
>>> > >
>>> >
>>> >
>>> >
>>> > --
>>> >
>>> > Regards,
>>> > Ashish
>>> >
>>>
>>>
>>>
>>> --
>>> Thanks,
>>> Neha
>>>
>>
>>
>>
>> --
>>
>> Regards,
>> Ashish
>>
>
>
>
> --
>
> Regards,
> Ashish
>
Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Posted by Gwen Shapira <gs...@cloudera.com>.
+1 (non-binding)
On Tue, Jun 23, 2015 at 11:24 AM, Neha Narkhede <ne...@confluent.io> wrote:
> +1
>
> On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com> wrote:
>
>> Hey Guys,
>>
>> We had some discussion over mail and in KIP hangout. I will update the RB
>> with proposed changes.
>>
>>
>> On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
>> wrote:
>>
>> > Hi Neha,
>> >
>> > Answers inline.
>> >
>> > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
>> wrote:
>> >
>> >> Thanks for submitting the KIP, Ashish! Few questions.
>> >>
>> >> 1. Can you specify more details around how you expect csv output to be
>> >> used. Same for json.
>> >>
>> > CSV takes less storage space and is more convenient for shell operations.
>> > A simple diff between two csv outputs would tell you if something changed
>> > or not. It's also common in certain industries when dealing with legacy
>> > systems and workflows. Try importing JSON into MS Excel.
>> >
>> > JSON on the other hand has easy interpretation, compact notation and
>> > supports Hierarchical Data. If someone is planning to run the tool
>> > periodically and send the output to some server or even just persist it
>> > somewhere, JSON is probably the way to go.
>> >
>> > 2. If we add these options, would you still need the old format. If
>> >> csv/json offers more convenience, should we have a plan to phase out the
>> >> old format?
>> >>
>> > Probably not, but having it around will not hurt. Having three output
>> > formats is not that bad and I do not expect this list to grow in future.
>> >
>> >>
>> >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
>> >> wrote:
>> >>
>> >> > Jun,
>> >> >
>> >> > Can we add this as part of next KIP's agenda?
>> >> >
>> >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
>> >> > wrote:
>> >> >
>> >> > > Maybe bring it up at the next KIP call, to make sure everyone is
>> >> aware?
>> >> > >
>> >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
>> >> > wrote:
>> >> > > > Hi Guys,
>> >> > > >
>> >> > > > This has been lying around for quite some time. Should I start a
>> >> voting
>> >> > > > thread on this?
>> >> > > >
>> >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
>> asingh@cloudera.com>
>> >> > > wrote:
>> >> > > >
>> >> > > >> Had to change the title of the page and that surprisingly changed
>> >> the
>> >> > > link
>> >> > > >> as well. KIP-23 is now available at here
>> >> > > >> <
>> >> > >
>> >> >
>> >>
>> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
>> >> >
>> >> > > >> .
>> >> > > >>
>> >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
>> asingh@cloudera.com
>> >> >
>> >> > > wrote:
>> >> > > >>
>> >> > > >>> Hi Guys,
>> >> > > >>>
>> >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
>> >> options
>> >> > to
>> >> > > >>> ConsumerGroupCommand
>> >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
>> >> > > KAFKA-313
>> >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
>> >> made
>> >> > as
>> >> > > >>> part of the JIRA can be found here <
>> >> > > https://reviews.apache.org/r/28096/>.
>> >> > > >>>
>> >> > > >>> Comments and suggestions are welcome!
>> >> > > >>>
>> >> > > >>> --
>> >> > > >>>
>> >> > > >>> Regards,
>> >> > > >>> Ashish
>> >> > > >>>
>> >> > > >>
>> >> > > >>
>> >> > > >>
>> >> > > >> --
>> >> > > >>
>> >> > > >> Regards,
>> >> > > >> Ashish
>> >> > > >>
>> >> > > >
>> >> > > >
>> >> > > >
>> >> > > > --
>> >> > > >
>> >> > > > Regards,
>> >> > > > Ashish
>> >> > >
>> >> >
>> >> >
>> >> >
>> >> > --
>> >> >
>> >> > Regards,
>> >> > Ashish
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Thanks,
>> >> Neha
>> >>
>> >
>> >
>> >
>> > --
>> >
>> > Regards,
>> > Ashish
>> >
>>
>>
>>
>> --
>>
>> Regards,
>> Ashish
>>
>
>
>
> --
> Thanks,
> Neha
RE: [VOTE] KIP-23 - Add JSON/CSV output and looping options to
ConsumerGroupCommand
Posted by Aditya Auradkar <aa...@linkedin.com.INVALID>.
Thanks. +1 (non-binding)
________________________________________
From: Ashish Singh [asingh@cloudera.com]
Sent: Tuesday, June 23, 2015 12:04 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Aditya,
Yes. Updated the KIP with notes on the parameter. Will update the patch.
On Tue, Jun 23, 2015 at 11:51 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Hey Ashish,
>
> Last hangout, I think we discussed adding a "num-iterations" parameter to
> the script. Do you plan to support that?
>
> Aditya
>
> ________________________________________
> From: Neha Narkhede [neha@confluent.io]
> Sent: Tuesday, June 23, 2015 11:24 AM
> To: dev@kafka.apache.org
> Cc: Jun Rao
> Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to
> ConsumerGroupCommand
>
> +1
>
> On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
> > Hey Guys,
> >
> > We had some discussion over mail and in KIP hangout. I will update the RB
> > with proposed changes.
> >
> >
> > On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
> > wrote:
> >
> > > Hi Neha,
> > >
> > > Answers inline.
> > >
> > > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
> > wrote:
> > >
> > >> Thanks for submitting the KIP, Ashish! Few questions.
> > >>
> > >> 1. Can you specify more details around how you expect csv output to be
> > >> used. Same for json.
> > >>
> > > CSV takes less storage space and is more convenient for shell
> operations.
> > > A simple diff between two csv outputs would tell you if something
> changed
> > > or not. It's also common in certain industries when dealing with legacy
> > > systems and workflows. Try importing JSON into MS Excel.
> > >
> > > JSON on the other hand has easy interpretation, compact notation and
> > > supports Hierarchical Data. If someone is planning to run the tool
> > > periodically and send the output to some server or even just persist it
> > > somewhere, JSON is probably the way to go.
> > >
> > > 2. If we add these options, would you still need the old format. If
> > >> csv/json offers more convenience, should we have a plan to phase out
> the
> > >> old format?
> > >>
> > > Probably not, but having it around will not hurt. Having three output
> > > formats is not that bad and I do not expect this list to grow in
> future.
> > >
> > >>
> > >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
> > >> wrote:
> > >>
> > >> > Jun,
> > >> >
> > >> > Can we add this as part of next KIP's agenda?
> > >> >
> > >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <
> gshapira@cloudera.com>
> > >> > wrote:
> > >> >
> > >> > > Maybe bring it up at the next KIP call, to make sure everyone is
> > >> aware?
> > >> > >
> > >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <
> asingh@cloudera.com>
> > >> > wrote:
> > >> > > > Hi Guys,
> > >> > > >
> > >> > > > This has been lying around for quite some time. Should I start a
> > >> voting
> > >> > > > thread on this?
> > >> > > >
> > >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
> > asingh@cloudera.com>
> > >> > > wrote:
> > >> > > >
> > >> > > >> Had to change the title of the page and that surprisingly
> changed
> > >> the
> > >> > > link
> > >> > > >> as well. KIP-23 is now available at here
> > >> > > >> <
> > >> > >
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
> > >> >
> > >> > > >> .
> > >> > > >>
> > >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
> > asingh@cloudera.com
> > >> >
> > >> > > wrote:
> > >> > > >>
> > >> > > >>> Hi Guys,
> > >> > > >>>
> > >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
> > >> options
> > >> > to
> > >> > > >>> ConsumerGroupCommand
> > >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>,
> for
> > >> > > KAFKA-313
> > >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The
> changes
> > >> made
> > >> > as
> > >> > > >>> part of the JIRA can be found here <
> > >> > > https://reviews.apache.org/r/28096/>.
> > >> > > >>>
> > >> > > >>> Comments and suggestions are welcome!
> > >> > > >>>
> > >> > > >>> --
> > >> > > >>>
> > >> > > >>> Regards,
> > >> > > >>> Ashish
> > >> > > >>>
> > >> > > >>
> > >> > > >>
> > >> > > >>
> > >> > > >> --
> > >> > > >>
> > >> > > >> Regards,
> > >> > > >> Ashish
> > >> > > >>
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > >
> > >> > > > Regards,
> > >> > > > Ashish
> > >> > >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> >
> > >> > Regards,
> > >> > Ashish
> > >> >
> > >>
> > >>
> > >>
> > >> --
> > >> Thanks,
> > >> Neha
> > >>
> > >
> > >
> > >
> > > --
> > >
> > > Regards,
> > > Ashish
> > >
> >
> >
> >
> > --
> >
> > Regards,
> > Ashish
> >
>
>
>
> --
> Thanks,
> Neha
>
--
Regards,
Ashish
Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Posted by Ashish Singh <as...@cloudera.com>.
Aditya,
Yes. Updated the KIP with notes on the parameter. Will update the patch.
On Tue, Jun 23, 2015 at 11:51 AM, Aditya Auradkar <
aauradkar@linkedin.com.invalid> wrote:
> Hey Ashish,
>
> Last hangout, I think we discussed adding a "num-iterations" parameter to
> the script. Do you plan to support that?
>
> Aditya
>
> ________________________________________
> From: Neha Narkhede [neha@confluent.io]
> Sent: Tuesday, June 23, 2015 11:24 AM
> To: dev@kafka.apache.org
> Cc: Jun Rao
> Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to
> ConsumerGroupCommand
>
> +1
>
> On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
> > Hey Guys,
> >
> > We had some discussion over mail and in KIP hangout. I will update the RB
> > with proposed changes.
> >
> >
> > On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
> > wrote:
> >
> > > Hi Neha,
> > >
> > > Answers inline.
> > >
> > > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
> > wrote:
> > >
> > >> Thanks for submitting the KIP, Ashish! Few questions.
> > >>
> > >> 1. Can you specify more details around how you expect csv output to be
> > >> used. Same for json.
> > >>
> > > CSV takes less storage space and is more convenient for shell
> operations.
> > > A simple diff between two csv outputs would tell you if something
> changed
> > > or not. It's also common in certain industries when dealing with legacy
> > > systems and workflows. Try importing JSON into MS Excel.
> > >
> > > JSON on the other hand has easy interpretation, compact notation and
> > > supports Hierarchical Data. If someone is planning to run the tool
> > > periodically and send the output to some server or even just persist it
> > > somewhere, JSON is probably the way to go.
> > >
> > > 2. If we add these options, would you still need the old format. If
> > >> csv/json offers more convenience, should we have a plan to phase out
> the
> > >> old format?
> > >>
> > > Probably not, but having it around will not hurt. Having three output
> > > formats is not that bad and I do not expect this list to grow in
> future.
> > >
> > >>
> > >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
> > >> wrote:
> > >>
> > >> > Jun,
> > >> >
> > >> > Can we add this as part of next KIP's agenda?
> > >> >
> > >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <
> gshapira@cloudera.com>
> > >> > wrote:
> > >> >
> > >> > > Maybe bring it up at the next KIP call, to make sure everyone is
> > >> aware?
> > >> > >
> > >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <
> asingh@cloudera.com>
> > >> > wrote:
> > >> > > > Hi Guys,
> > >> > > >
> > >> > > > This has been lying around for quite some time. Should I start a
> > >> voting
> > >> > > > thread on this?
> > >> > > >
> > >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
> > asingh@cloudera.com>
> > >> > > wrote:
> > >> > > >
> > >> > > >> Had to change the title of the page and that surprisingly
> changed
> > >> the
> > >> > > link
> > >> > > >> as well. KIP-23 is now available at here
> > >> > > >> <
> > >> > >
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
> > >> >
> > >> > > >> .
> > >> > > >>
> > >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
> > asingh@cloudera.com
> > >> >
> > >> > > wrote:
> > >> > > >>
> > >> > > >>> Hi Guys,
> > >> > > >>>
> > >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
> > >> options
> > >> > to
> > >> > > >>> ConsumerGroupCommand
> > >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>,
> for
> > >> > > KAFKA-313
> > >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The
> changes
> > >> made
> > >> > as
> > >> > > >>> part of the JIRA can be found here <
> > >> > > https://reviews.apache.org/r/28096/>.
> > >> > > >>>
> > >> > > >>> Comments and suggestions are welcome!
> > >> > > >>>
> > >> > > >>> --
> > >> > > >>>
> > >> > > >>> Regards,
> > >> > > >>> Ashish
> > >> > > >>>
> > >> > > >>
> > >> > > >>
> > >> > > >>
> > >> > > >> --
> > >> > > >>
> > >> > > >> Regards,
> > >> > > >> Ashish
> > >> > > >>
> > >> > > >
> > >> > > >
> > >> > > >
> > >> > > > --
> > >> > > >
> > >> > > > Regards,
> > >> > > > Ashish
> > >> > >
> > >> >
> > >> >
> > >> >
> > >> > --
> > >> >
> > >> > Regards,
> > >> > Ashish
> > >> >
> > >>
> > >>
> > >>
> > >> --
> > >> Thanks,
> > >> Neha
> > >>
> > >
> > >
> > >
> > > --
> > >
> > > Regards,
> > > Ashish
> > >
> >
> >
> >
> > --
> >
> > Regards,
> > Ashish
> >
>
>
>
> --
> Thanks,
> Neha
>
--
Regards,
Ashish
RE: [VOTE] KIP-23 - Add JSON/CSV output and looping options to
ConsumerGroupCommand
Posted by Aditya Auradkar <aa...@linkedin.com.INVALID>.
Hey Ashish,
Last hangout, I think we discussed adding a "num-iterations" parameter to the script. Do you plan to support that?
Aditya
________________________________________
From: Neha Narkhede [neha@confluent.io]
Sent: Tuesday, June 23, 2015 11:24 AM
To: dev@kafka.apache.org
Cc: Jun Rao
Subject: Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
+1
On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com> wrote:
> Hey Guys,
>
> We had some discussion over mail and in KIP hangout. I will update the RB
> with proposed changes.
>
>
> On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
> > Hi Neha,
> >
> > Answers inline.
> >
> > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
> wrote:
> >
> >> Thanks for submitting the KIP, Ashish! Few questions.
> >>
> >> 1. Can you specify more details around how you expect csv output to be
> >> used. Same for json.
> >>
> > CSV takes less storage space and is more convenient for shell operations.
> > A simple diff between two csv outputs would tell you if something changed
> > or not. It's also common in certain industries when dealing with legacy
> > systems and workflows. Try importing JSON into MS Excel.
> >
> > JSON on the other hand has easy interpretation, compact notation and
> > supports Hierarchical Data. If someone is planning to run the tool
> > periodically and send the output to some server or even just persist it
> > somewhere, JSON is probably the way to go.
> >
> > 2. If we add these options, would you still need the old format. If
> >> csv/json offers more convenience, should we have a plan to phase out the
> >> old format?
> >>
> > Probably not, but having it around will not hurt. Having three output
> > formats is not that bad and I do not expect this list to grow in future.
> >
> >>
> >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
> >> wrote:
> >>
> >> > Jun,
> >> >
> >> > Can we add this as part of next KIP's agenda?
> >> >
> >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
> >> > wrote:
> >> >
> >> > > Maybe bring it up at the next KIP call, to make sure everyone is
> >> aware?
> >> > >
> >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
> >> > wrote:
> >> > > > Hi Guys,
> >> > > >
> >> > > > This has been lying around for quite some time. Should I start a
> >> voting
> >> > > > thread on this?
> >> > > >
> >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
> asingh@cloudera.com>
> >> > > wrote:
> >> > > >
> >> > > >> Had to change the title of the page and that surprisingly changed
> >> the
> >> > > link
> >> > > >> as well. KIP-23 is now available at here
> >> > > >> <
> >> > >
> >> >
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
> >> >
> >> > > >> .
> >> > > >>
> >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
> asingh@cloudera.com
> >> >
> >> > > wrote:
> >> > > >>
> >> > > >>> Hi Guys,
> >> > > >>>
> >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
> >> options
> >> > to
> >> > > >>> ConsumerGroupCommand
> >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
> >> > > KAFKA-313
> >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
> >> made
> >> > as
> >> > > >>> part of the JIRA can be found here <
> >> > > https://reviews.apache.org/r/28096/>.
> >> > > >>>
> >> > > >>> Comments and suggestions are welcome!
> >> > > >>>
> >> > > >>> --
> >> > > >>>
> >> > > >>> Regards,
> >> > > >>> Ashish
> >> > > >>>
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> --
> >> > > >>
> >> > > >> Regards,
> >> > > >> Ashish
> >> > > >>
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > >
> >> > > > Regards,
> >> > > > Ashish
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> >
> >> > Regards,
> >> > Ashish
> >> >
> >>
> >>
> >>
> >> --
> >> Thanks,
> >> Neha
> >>
> >
> >
> >
> > --
> >
> > Regards,
> > Ashish
> >
>
>
>
> --
>
> Regards,
> Ashish
>
--
Thanks,
Neha
Re: [VOTE] KIP-23 - Add JSON/CSV output and looping options to ConsumerGroupCommand
Posted by Neha Narkhede <ne...@confluent.io>.
+1
On Tue, Jun 23, 2015 at 11:15 AM, Ashish Singh <as...@cloudera.com> wrote:
> Hey Guys,
>
> We had some discussion over mail and in KIP hangout. I will update the RB
> with proposed changes.
>
>
> On Sun, Jun 14, 2015 at 10:07 AM, Ashish Singh <as...@cloudera.com>
> wrote:
>
> > Hi Neha,
> >
> > Answers inline.
> >
> > On Thu, Jun 11, 2015 at 7:20 PM, Neha Narkhede <ne...@confluent.io>
> wrote:
> >
> >> Thanks for submitting the KIP, Ashish! Few questions.
> >>
> >> 1. Can you specify more details around how you expect csv output to be
> >> used. Same for json.
> >>
> > CSV takes less storage space and is more convenient for shell operations.
> > A simple diff between two csv outputs would tell you if something changed
> > or not. It's also common in certain industries when dealing with legacy
> > systems and workflows. Try importing JSON into MS Excel.
> >
> > JSON on the other hand has easy interpretation, compact notation and
> > supports Hierarchical Data. If someone is planning to run the tool
> > periodically and send the output to some server or even just persist it
> > somewhere, JSON is probably the way to go.
> >
> > 2. If we add these options, would you still need the old format. If
> >> csv/json offers more convenience, should we have a plan to phase out the
> >> old format?
> >>
> > Probably not, but having it around will not hurt. Having three output
> > formats is not that bad and I do not expect this list to grow in future.
> >
> >>
> >> On Thu, Jun 11, 2015 at 6:05 PM, Ashish Singh <as...@cloudera.com>
> >> wrote:
> >>
> >> > Jun,
> >> >
> >> > Can we add this as part of next KIP's agenda?
> >> >
> >> > On Thu, Jun 11, 2015 at 3:00 PM, Gwen Shapira <gs...@cloudera.com>
> >> > wrote:
> >> >
> >> > > Maybe bring it up at the next KIP call, to make sure everyone is
> >> aware?
> >> > >
> >> > > On Thu, Jun 11, 2015 at 2:17 PM, Ashish Singh <as...@cloudera.com>
> >> > wrote:
> >> > > > Hi Guys,
> >> > > >
> >> > > > This has been lying around for quite some time. Should I start a
> >> voting
> >> > > > thread on this?
> >> > > >
> >> > > > On Thu, May 7, 2015 at 12:20 PM, Ashish Singh <
> asingh@cloudera.com>
> >> > > wrote:
> >> > > >
> >> > > >> Had to change the title of the page and that surprisingly changed
> >> the
> >> > > link
> >> > > >> as well. KIP-23 is now available at here
> >> > > >> <
> >> > >
> >> >
> >>
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=56852556
> >> >
> >> > > >> .
> >> > > >>
> >> > > >> On Thu, May 7, 2015 at 11:34 AM, Ashish Singh <
> asingh@cloudera.com
> >> >
> >> > > wrote:
> >> > > >>
> >> > > >>> Hi Guys,
> >> > > >>>
> >> > > >>> I just added a KIP, KIP-23 - Add JSON/CSV output and looping
> >> options
> >> > to
> >> > > >>> ConsumerGroupCommand
> >> > > >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-23>, for
> >> > > KAFKA-313
> >> > > >>> <https://issues.apache.org/jira/browse/KAFKA-313>. The changes
> >> made
> >> > as
> >> > > >>> part of the JIRA can be found here <
> >> > > https://reviews.apache.org/r/28096/>.
> >> > > >>>
> >> > > >>> Comments and suggestions are welcome!
> >> > > >>>
> >> > > >>> --
> >> > > >>>
> >> > > >>> Regards,
> >> > > >>> Ashish
> >> > > >>>
> >> > > >>
> >> > > >>
> >> > > >>
> >> > > >> --
> >> > > >>
> >> > > >> Regards,
> >> > > >> Ashish
> >> > > >>
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > >
> >> > > > Regards,
> >> > > > Ashish
> >> > >
> >> >
> >> >
> >> >
> >> > --
> >> >
> >> > Regards,
> >> > Ashish
> >> >
> >>
> >>
> >>
> >> --
> >> Thanks,
> >> Neha
> >>
> >
> >
> >
> > --
> >
> > Regards,
> > Ashish
> >
>
>
>
> --
>
> Regards,
> Ashish
>
--
Thanks,
Neha