You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "Dong Lin (JIRA)" <ji...@apache.org> on 2014/07/18 22:00:09 UTC

[jira] [Created] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

Dong Lin created KAFKA-1550:
-------------------------------

             Summary: Patch review tool should use git format-patch to generate patch
                 Key: KAFKA-1550
                 URL: https://issues.apache.org/jira/browse/KAFKA-1550
             Project: Kafka
          Issue Type: Bug
            Reporter: Dong Lin
            Assignee: Dong Lin
            Priority: Minor


kafka-patch-review.py uses git-diff to generate patch for jira ticket. The resulting patch includes local uncommitted changes and is therefore different from the patch published to reviewboard.
kafka-patch-review.py updates the jira ticket with attaching patch even if the reviewboard specified in --rb option is not found.



--
This message was sent by Atlassian JIRA
(v6.2#6252)