[GitHub] Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false

[GitBox <gi...@apache.org>]

Tibor17 commented on a change in pull request #213: [SUREFIRE-1534] ClassNotFoundException: org.apache.maven.plugin.surefire.StartupReportConfiguration using reuseForks set to false
URL: https://github.com/apache/maven-surefire/pull/213#discussion_r249273047
 
 

 ##########
 File path: surefire-its/src/test/java/org/apache/maven/surefire/its/JUnitPlatformEnginesIT.java
 ##########
 @@ -114,7 +114,8 @@ public void platform() throws VerificationException
                 + "  surefire-api-*.jar"
                 + "  surefire-logger-api-*.jar"
                 + "  common-java5-*.jar"
-                + "  junit-platform-launcher-1.3.1.jar";
+                + "  junit-platform-launcher-1.3.1.jar"
+                + "  maven-surefire-common-*.jar";
 
 Review comment:
   The provider classpath must not have surefire-common.
   This would require us ASF devs to modify this PR.
   User's motivation is very valuable.
   
   The in-plugin classpath is used in two cases:
   1. to run tests without forked VM and 
   2. filter tests before forking
   
   The problem is thata subtype (`ModularClasspathConfiguration`)  `AbstractPathConfiguration.getInprocClasspath()` returns empty CP.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services