You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2021/03/18 07:02:57 UTC

svn commit: r1887772 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java

Author: lehmi
Date: Thu Mar 18 07:02:56 2021
New Revision: 1887772

URL: http://svn.apache.org/viewvc?rev=1887772&view=rev
Log:
PDFBOX-4892: use convenience methods to simplify code

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1887772&r1=1887771&r2=1887772&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Thu Mar 18 07:02:56 2021
@@ -1939,13 +1939,13 @@ public class COSParser extends BaseParse
         if (trailerWasRebuild)
         {
             // check if all page objects are dereferenced
-            COSBase pages = root.getDictionaryObject(COSName.PAGES);
-            if (pages instanceof COSDictionary)
+            COSDictionary pages = root.getCOSDictionary(COSName.PAGES);
+            if (pages != null)
             {
-                checkPagesDictionary((COSDictionary) pages, new HashSet<>());
+                checkPagesDictionary(pages, new HashSet<>());
             }
         }
-        if (!(root.getDictionaryObject(COSName.PAGES) instanceof COSDictionary))
+        if (root.getCOSDictionary(COSName.PAGES) == null)
         {
             throw new IOException("Page tree root must be a dictionary");
         }
@@ -1954,11 +1954,10 @@ public class COSParser extends BaseParse
     private int checkPagesDictionary(COSDictionary pagesDict, Set<COSObject> set)
     {
         // check for kids
-        COSBase kids = pagesDict.getDictionaryObject(COSName.KIDS);
+        COSArray kidsArray = pagesDict.getCOSArray(COSName.KIDS);
         int numberOfPages = 0;
-        if (kids instanceof COSArray)
+        if (kidsArray != null)
         {
-            COSArray kidsArray = (COSArray) kids;
             List<? extends COSBase> kidsList = kidsArray.toList();
             for (COSBase kid : kidsList)
             {