You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/18 19:53:09 UTC
[GitHub] [airflow] Gollum999 opened a new pull request, #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Gollum999 opened a new pull request, #26463:
URL: https://github.com/apache/airflow/pull/26463
This reverts commit de6938e173773d88bd741e43c7b0aa16d8a1a167.
See discussion in #24844.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #26463:
URL: https://github.com/apache/airflow/pull/26463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26463:
URL: https://github.com/apache/airflow/pull/26463#issuecomment-1254019584
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #26463:
URL: https://github.com/apache/airflow/pull/26463#issuecomment-1252467789
> Anyone have a recommendation for the best way to fix this? Typescript is not my forte.
>
> ```
> static/js/api/useGridData.test.ts:39:7 - error TS2322: Type '{ runId: string; executionDate: string; dataIntervalStart: string; dataIntervalEnd: string; runType: string; startDate: null; endDate: null; lastSchedulingDecision: null; state: "success"; }' is not assignable to type 'DagRun'.
> Types of property 'runType' are incompatible.
> Type 'string' is not assignable to type '"backfill" | "manual" | "scheduled" | "dataset_triggered"'.
>
> 39 { state: 'success', ...commonDagRunParams },
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ```
Typescript isn't interpreting the string as the real enum. We can either do an `as` casting or define `runType` before `commonDagRunParams` like so:
```
const runType: DagRun['runType'] = 'scheduled';
const commonDagRunParams = {
runId: 'runId',
executionDate: '2022-01-01T10:00+00:00',
dataIntervalStart: '2022-01-01T05:00+00:00',
dataIntervalEnd: '2022-01-01T10:00+00:00',
runType,
startDate: null,
endDate: null,
lastSchedulingDecision: null,
};
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #26463:
URL: https://github.com/apache/airflow/pull/26463#issuecomment-1250375747
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Gollum999 commented on pull request #26463: Revert "No grid auto-refresh for backfill dag runs (#25042)"
Posted by GitBox <gi...@apache.org>.
Gollum999 commented on PR #26463:
URL: https://github.com/apache/airflow/pull/26463#issuecomment-1250521148
Anyone have a recommendation for the best way to fix this? Typescript is not my forte.
```
static/js/api/useGridData.test.ts:39:7 - error TS2322: Type '{ runId: string; executionDate: string; dataIntervalStart: string; dataIntervalEnd: string; runType: string; startDate: null; endDate: null; lastSchedulingDecision: null; state: "success"; }' is not assignable to type 'DagRun'.
Types of property 'runType' are incompatible.
Type 'string' is not assignable to type '"backfill" | "manual" | "scheduled" | "dataset_triggered"'.
39 { state: 'success', ...commonDagRunParams },
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org