You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/20 06:42:03 UTC
Review Request 35686: Change the if statement to a CHECK at the end of
_runTask.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Follow-up from [r35433](https://reviews.apache.org/r/35433/#comment141187).
Diffs
-----
src/slave/slave.cpp e73913b072e323033a81e64b5345cb9457137e3e
Diff: https://reviews.apache.org/r/35686/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35686: Change the if statement to a CHECK at the
end of _runTask.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88812
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On June 20, 2015, 4:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35686/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 4:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35433](https://reviews.apache.org/r/35433/#comment141187).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e73913b072e323033a81e64b5345cb9457137e3e
>
> Diff: https://reviews.apache.org/r/35686/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35686: Change the if statement to a CHECK at the
end of _runTask.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88635
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On June 20, 2015, 4:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35686/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 4:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35433](https://reviews.apache.org/r/35433/#comment141187).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e73913b072e323033a81e64b5345cb9457137e3e
>
> Diff: https://reviews.apache.org/r/35686/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35686: Change the if statement to a CHECK at the
end of _runTask.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88663
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35686]
All tests passed.
- Mesos ReviewBot
On June 20, 2015, 4:42 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35686/
> -----------------------------------------------------------
>
> (Updated June 20, 2015, 4:42 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35433](https://reviews.apache.org/r/35433/#comment141187).
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e73913b072e323033a81e64b5345cb9457137e3e
>
> Diff: https://reviews.apache.org/r/35686/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>