You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/14 15:08:07 UTC
[GitHub] [incubator-superset] kgabryje opened a new pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
kgabryje opened a new pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
### SUMMARY
Re-enable ESLint rule `no-access-state-in-setstate`, which was disabled in PR #10839. Code was refactored to fix the errors raised by the rule.
### TEST PLAN
Run `npm run lint`, verify that there are no new Javascript/Typescript errors.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-694954689
I re-triggered the action in CI, if that doesn't work you can rebase as the issue has been addressed on `master`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=h1) Report
> Merging [#10870](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d93b2b99b28c66f0815637b9f8a5fecae3a4e33c?el=desc) will **increase** coverage by `2.78%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10870 +/- ##
==========================================
+ Coverage 59.21% 61.99% +2.78%
==========================================
Files 776 382 -394
Lines 37040 24595 -12445
Branches 3309 0 -3309
==========================================
- Hits 21932 15247 -6685
+ Misses 14922 9348 -5574
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `61.99% <ø> (+0.69%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `87.94% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
| [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
| [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | |
| [...set-frontend/src/dashboard/util/resizableConfig.ts](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Jlc2l6YWJsZUNvbmZpZy50cw==) | | |
| [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | | |
| [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | | |
| [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=footer). Last update [d93b2b9...9e6a742](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-695836328
@mistercrunch I rebased this PR on the newest master and retriggered the CI a couple of times but it keeps failing the cypress tests (explore/AdhocMetrics.test.ts). @eschutho do you have any idea how we could fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-695840072
> @mistercrunch I rebased this PR on the newest master and retriggered the CI a couple of times but it keeps failing the cypress tests (explore/AdhocMetrics.test.ts). @eschutho do you have any idea how we could fix this?
And just as I wrote this comment I figured that the issue is in my code and not in Cypress... I accessed `event.target.value` in an async function and React's good old event pooling made sure that the `target` field was undefined. It's fixed now - I moved accessing the value to synchronous part of event handler. Sorry for confusion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-695836328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=h1) Report
> Merging [#10870](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e21a354b3b560465a866c25dd687fbeef73eee31?el=desc) will **decrease** coverage by `4.23%`.
> The diff coverage is `28.94%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10870 +/- ##
==========================================
- Coverage 65.80% 61.57% -4.24%
==========================================
Files 815 815
Lines 38337 38339 +2
Branches 3601 3601
==========================================
- Hits 25228 23607 -1621
- Misses 13005 14546 +1541
- Partials 104 186 +82
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `61.75% <28.94%> (-0.01%)` | :arrow_down: |
| #python | `61.47% <ø> (+0.02%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/CRUD/CollectionTable.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvQ29sbGVjdGlvblRhYmxlLnRzeA==) | `69.15% <0.00%> (-17.76%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `76.51% <0.00%> (-4.55%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SaveQuery.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVRdWVyeS5qc3g=) | `77.77% <0.00%> (ø)` | |
| [...tend/src/SqlLab/components/ScheduleQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24uanN4) | `8.62% <0.00%> (ø)` | |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `74.02% <0.00%> (-8.45%)` | :arrow_down: |
| [superset-frontend/src/components/OmniContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci5qc3g=) | `12.50% <0.00%> (-45.84%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `40.90% <0.00%> (-40.91%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.63% <0.00%> (-55.32%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.77% <0.00%> (-1.39%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `69.58% <0.00%> (-3.47%)` | :arrow_down: |
| ... and [186 more](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=footer). Last update [e21a354...0f5dc77](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=h1) Report
> Merging [#10870](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d93b2b99b28c66f0815637b9f8a5fecae3a4e33c?el=desc) will **increase** coverage by `2.78%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10870 +/- ##
==========================================
+ Coverage 59.21% 61.99% +2.78%
==========================================
Files 776 382 -394
Lines 37040 24595 -12445
Branches 3309 0 -3309
==========================================
- Hits 21932 15247 -6685
+ Misses 14922 9348 -5574
+ Partials 186 0 -186
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #python | `61.99% <ø> (+0.69%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `87.94% <0.00%> (-0.38%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
| [...-frontend/src/components/IndeterminateCheckbox.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW5kZXRlcm1pbmF0ZUNoZWNrYm94LnRzeA==) | | |
| [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | | |
| [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
| [superset-frontend/src/components/Menu/Menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LnRzeA==) | | |
| [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | | |
| [...rontend/src/explore/components/AggregateOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZ2dyZWdhdGVPcHRpb24uanN4) | | |
| ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=footer). Last update [d93b2b9...9e6a742](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=h1) Report
> Merging [#10870](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/557a303cc5a05eeeef9cfce7c98da859904cf1c2?el=desc) will **decrease** coverage by `5.40%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10870 +/- ##
==========================================
- Coverage 65.80% 60.40% -5.41%
==========================================
Files 815 382 -433
Lines 38327 24124 -14203
Branches 3600 0 -3600
==========================================
- Hits 25221 14572 -10649
+ Misses 13002 9552 -3450
+ Partials 104 0 -104
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.40% <ø> (-1.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.16% <0.00%> (-12.50%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `70.85% <0.00%> (-11.44%)` | :arrow_down: |
| [superset/databases/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `85.71% <0.00%> (-8.17%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
| [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=footer). Last update [557a303...26265a0](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] kgabryje closed pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate
Posted by GitBox <gi...@apache.org>.
kgabryje closed pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org