You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2017/02/10 20:18:49 UTC
Re: Review Request 55173: Flume metrics can't show if hostname of
flume agent is not lowercase
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55173/#review165164
-----------------------------------------------------------
Ship it!
Hi Yao Lei,
Thank you for the contribution. I have opened up a Jira to make sure this is correctly addressed throuhout AMS.
https://issues.apache.org/jira/browse/AMBARI-19969
I am committing you patch to trunk.
- Sid Wagle
On Jan. 9, 2017, 6:27 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55173/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2017, 6:27 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Matt, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-19357
> https://issues.apache.org/jira/browse/AMBARI-19357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If hostname of flume agent is uppercase or mixed-case?web client will not show flume metrics normally.
> This is because we will query metric records by lowercase hostname used in ambari ,but the hostname in METRIC_RECORD is not lowercase (see attached picture),so we will not get any records.
> This patch amis to convert hostname of metric record of flume to lowercase before inserting into ams hbase.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java c1b684b
>
> Diff: https://reviews.apache.org/r/55173/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> yao lei
>
>
Re: Review Request 55173: Flume metrics can't show if hostname of
flume agent is not lowercase
Posted by yao lei <le...@163.com>.
> On \u4e8c\u6708 10, 2017, 8:18 p.m., Sid Wagle wrote:
> > Hi Yao Lei,
> >
> > Thank you for the contribution. I have opened up a Jira to make sure this is correctly addressed throuhout AMS.
> > https://issues.apache.org/jira/browse/AMBARI-19969
> >
> > I am committing you patch to trunk.
Hi Sid Wagle,
Thank you very much.
- yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55173/#review165164
-----------------------------------------------------------
On \u4e00\u6708 9, 2017, 6:27 a.m., yao lei wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55173/
> -----------------------------------------------------------
>
> (Updated \u4e00\u6708 9, 2017, 6:27 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Matt, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-19357
> https://issues.apache.org/jira/browse/AMBARI-19357
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If hostname of flume agent is uppercase or mixed-case?web client will not show flume metrics normally.
> This is because we will query metric records by lowercase hostname used in ambari ,but the hostname in METRIC_RECORD is not lowercase (see attached picture),so we will not get any records.
> This patch amis to convert hostname of metric record of flume to lowercase before inserting into ams hbase.
>
>
> Diffs
> -----
>
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java c1b684b
>
> Diff: https://reviews.apache.org/r/55173/diff/
>
>
> Testing
> -------
>
> Manually Tested
>
>
> Thanks,
>
> yao lei
>
>