You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "daniancu (via GitHub)" <gi...@apache.org> on 2026/04/14 12:49:37 UTC
[PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
daniancu opened a new pull request, #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55
## Summary
- Replace fire-and-forget `java.util.Timer` in `startProcessing()` with a `ScheduledExecutorService` that is properly shut down on `deactivate()`, preventing thread leaks
- Add package-private `setScheduler()` so tests can inject a controllable scheduler
- Rewrite `testTopologyChange` to use a `ManualScheduler` that captures tasks for on-demand execution, eliminating the flaky `Thread.sleep(4000)` and making the test deterministic and ~8x faster
## Test plan
- [x] `mvn test -Dtest=JobManagerConfigurationTest#testTopologyChange` — passes in ~1s (was ~9s)
- [x] `mvn test` — all 109 tests pass
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "daniancu (via GitHub)" <gi...@apache.org>.
daniancu commented on code in PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#discussion_r3086752712
##########
src/main/java/org/apache/sling/event/impl/jobs/config/JobManagerConfiguration.java:
##########
@@ -149,6 +151,14 @@ static JobManagerConfiguration newForTest(
return jobMgrConfig;
}
+ /**
+ * Replace the scheduler used for delayed topology change processing.
+ * Package-private for testability.
Review Comment:
it's just a backdoor for testing since tests don't use OSGi. in production we do not need to inject, it runs with the default one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4422727139
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4245234472
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4336242497
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4350609383
@stefanseifert IIRC you have a Windows system, can you please check this PR? I get constant failures in the CI for Windows machines, and I would like to understand if this is a Windows problem or rather a CI issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4715841081
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4789207587
thanks @daniancu for your contribution, it's merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4743246338
❌ The last analysis has failed.
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#discussion_r3451715777
##########
src/main/java/org/apache/sling/event/impl/jobs/config/JobManagerConfiguration.java:
##########
@@ -357,6 +363,10 @@ protected void deactivate() {
this.startupDelayListener.dispose();
this.startupDelayListener = null;
}
+ final ScheduledExecutorService s = this.scheduler.getAndSet(null);
+ if (s != null) {
Review Comment:
Can you add a brief comment, that this does only apply to tests?
##########
src/test/java/org/apache/sling/event/impl/jobs/config/JobManagerConfigurationTest.java:
##########
@@ -84,15 +84,17 @@ public void configurationChanged(boolean active) {
}
}
- @Test
- public void testTopologyChange() throws Exception {
- // mock scheduler
- final ChangeListener ccl = new ChangeListener();
+ @SuppressWarnings("unchecked")
+ private static void setScheduler(JobManagerConfiguration config, java.util.concurrent.ScheduledExecutorService s) {
+ ((java.util.concurrent.atomic.AtomicReference<java.util.concurrent.ScheduledExecutorService>)
Review Comment:
A package-level setter would probably be easier to use than reflection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4252673942
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4787343661
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4244619679
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate failed**
Failed conditions
 [68.4% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "henrykuijpers (via GitHub)" <gi...@apache.org>.
henrykuijpers commented on code in PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#discussion_r3086388708
##########
src/main/java/org/apache/sling/event/impl/jobs/config/JobManagerConfiguration.java:
##########
@@ -149,6 +151,14 @@ static JobManagerConfiguration newForTest(
return jobMgrConfig;
}
+ /**
+ * Replace the scheduler used for delayed topology change processing.
+ * Package-private for testability.
Review Comment:
This is an OSGi component, why would this `setScheduler` be needed, if simply another could be injected (if it was made so that it would be an OSGi service as well)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4342740852
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4370290431
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4743244818
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4788164260
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.5% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh merged PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4761985159
@daniancu can you please rebase from master? I worked on the ITs and improved their stability (SLING-13243)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "daniancu (via GitHub)" <gi...@apache.org>.
daniancu commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4253169900
## Changes since initial PR
**Commit 2 — Harden scheduler lifecycle**
- Use `AtomicReference<ScheduledExecutorService>` instead of `volatile` for thread-safe access
- `startProcessing()` reads the scheduler into a local variable, handles null (already deactivated), and catches `RejectedExecutionException` (shutdown race)
- `ManualScheduler` test fake now models realistic shutdown semantics
- Added `testDeactivatePreventsDelayedNotification` covering deactivation clearing pending tasks and schedule/shutdown race safety
**Commit 3 — Null scheduler tests**
- `testStartProcessingWithNullScheduler`: covers `scheduler.get() == null` branch
- `testDeactivateWithNullScheduler`: covers `deactivate()` when scheduler was never initialized, including double-deactivate
**Commit 4 — Extract ManualScheduler**
- Moved `ManualScheduler` from inner class to standalone package-private file
**Commit 5 — Remove setScheduler from production code**
- Removed the package-private `setScheduler()` setter from `JobManagerConfiguration`
- Tests now inject the scheduler via reflection (same pattern as `startupDelayListener`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4364559449
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4707594256
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4709427193
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4766064849
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4733122979
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4244186616
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate failed**
Failed conditions
 [B Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) (required ≥ A)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
##
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4777227917
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#discussion_r3085825908
##########
src/test/java/org/apache/sling/event/impl/jobs/config/JobManagerConfigurationTest.java:
##########
@@ -84,15 +88,173 @@ public void configurationChanged(boolean active) {
}
}
- @Test
- public void testTopologyChange() throws Exception {
- // mock scheduler
- final ChangeListener ccl = new ChangeListener();
+ /**
+ * A ScheduledExecutorService that captures submitted tasks without executing them.
+ * Models realistic shutdown semantics: {@link #shutdownNow()} marks the scheduler as shut down
+ * and clears pending tasks; {@link #schedule} after shutdown throws {@link RejectedExecutionException};
+ * {@link #runAll()} skips execution after shutdown.
+ */
+ private static class ManualScheduler implements ScheduledExecutorService {
Review Comment:
I would externalize this internal class into a dedicated class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-13170 Replace Timer with injectable ScheduledExecutorService [sling-org-apache-sling-event]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #55:
URL: https://github.com/apache/sling-org-apache-sling-event/pull/55#issuecomment-4253353924
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-event&pullRequest=55&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [88.2% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-event&pullRequest=55&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-event&pullRequest=55)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org