You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/01 16:04:08 UTC
[GitHub] [dubbo-go-pixiu] tydhot opened a new pull request #202: Enrich filter test case
tydhot opened a new pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#discussion_r662753328
##########
File path: pkg/filter/header/header_test.go
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package header
+
+import (
+ "bytes"
+ "github.com/apache/dubbo-go-pixiu/pkg/context/mock"
Review comment:
split it.
##########
File path: pkg/filter/logger/logger_test.go
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package logger
+
+import (
+ "bytes"
+ "github.com/apache/dubbo-go-pixiu/pkg/context/mock"
Review comment:
split it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81899cf) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 81899cf differs from pull request most recent head e65fc55. Consider uploading reports for the commit e65fc55 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...e65fc55](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567816b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 567816b differs from pull request most recent head 63059b4. Consider uploading reports for the commit 63059b4 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...63059b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567816b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...567816b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (422c26d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2b4af4d50480acd54271af1fd207709d649190d6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b4af4d) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.45% 37.54% +1.09%
===========================================
Files 36 39 +3
Lines 1934 1987 +53
===========================================
+ Hits 705 746 +41
- Misses 1134 1143 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2b4af4d...422c26d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (63059b4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...63059b4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e65fc55) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...e65fc55](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#discussion_r662753269
##########
File path: pkg/filter/authority/authority_test.go
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package authority
+
+import (
Review comment:
pls split this import block as other code files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (567816b) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/70e6fb7a40ae4ce87713eaa219f2427781d00401?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70e6fb7) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.39% 37.48% +1.09%
===========================================
Files 36 39 +3
Lines 1937 1990 +53
===========================================
+ Hits 705 746 +41
- Misses 1137 1146 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [70e6fb7...567816b](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872371428
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#202](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (422c26d) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/2b4af4d50480acd54271af1fd207709d649190d6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2b4af4d) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #202 +/- ##
===========================================
+ Coverage 36.45% 37.54% +1.09%
===========================================
Files 36 39 +3
Lines 1934 1987 +53
===========================================
+ Hits 705 746 +41
- Misses 1134 1143 +9
- Partials 95 98 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/filter/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9sb2dnZXIvbG9nZ2VyLmdv) | `75.00% <0.00%> (ø)` | |
| [pkg/filter/authority/authority.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9hdXRob3JpdHkvYXV0aG9yaXR5Lmdv) | `80.95% <0.00%> (ø)` | |
| [pkg/filter/header/header.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2ZpbHRlci9oZWFkZXIvaGVhZGVyLmdv) | `75.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [2b4af4d...422c26d](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/202?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] tydhot commented on pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
tydhot commented on pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#issuecomment-872824975
@AlexStocks The imports is spilted now:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#discussion_r662753049
##########
File path: pkg/context/mock/context.go
##########
@@ -20,6 +20,7 @@ package mock
import (
"context"
"fmt"
+ "github.com/apache/dubbo-go-pixiu/pkg/model"
Review comment:
move it to the third import block. pls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] tydhot commented on a change in pull request #202: Enrich filter test case
Posted by GitBox <gi...@apache.org>.
tydhot commented on a change in pull request #202:
URL: https://github.com/apache/dubbo-go-pixiu/pull/202#discussion_r662756727
##########
File path: pkg/context/mock/context.go
##########
@@ -20,6 +20,7 @@ package mock
import (
"context"
"fmt"
+ "github.com/apache/dubbo-go-pixiu/pkg/model"
Review comment:
ok, I got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org