[GitHub] [rocketmq] TheR1sing3un commented on a diff in pull request #6100: [ISSUE #5989] Support unique broker-id as identification in controller mode

["TheR1sing3un (via GitHub)" <gi...@apache.org>]

TheR1sing3un commented on code in PR #6100:
URL: https://github.com/apache/rocketmq/pull/6100#discussion_r1113839415


##########
tools/src/main/java/org/apache/rocketmq/tools/command/controller/ReElectMasterSubCommand.java:
##########
@@ -45,7 +46,7 @@ public Options buildCommandlineOptions(Options options) {
         opt.setRequired(true);
         options.addOption(opt);
 
-        opt = new Option("b", "brokerAddress", true, "The address of the broker which requires to become master");

Review Comment:
   我觉得可以加一个命令获取对应关系，这样更规范一点，不需要在elemaster那里再更改一些逻辑了。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org