[GitHub] [pulsar-helm-chart] toneill818 commented on a change in pull request #48: Allow Grafana to work with a reverse proxy

[GitBox <gi...@apache.org>]

toneill818 commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-helm-chart/pull/48#discussion_r464662691



##########
File path: charts/pulsar/values.yaml
##########
@@ -856,16 +856,16 @@ grafana:
     targetPort: 3000
     annotations: {}
   plugins: []
+  ## Grafana configMap
+  ## templates/grafana-configmap.yaml
+  ##
+  configData: {}
   ## Grafana ingress
   ## templates/grafana-ingress.yaml
   ##
   ingress:
     enabled: false
-    annotations:

Review comment:
       They get merged with other values if a user provides annotations. This also matches the other ingress values. So if I am not using nginx ingress, it still attaches the nginx ingress annotations. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org