You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by jq...@apache.org on 2017/03/13 20:01:04 UTC
kafka git commit: KAFKA-4891; kafka.request.logger TRACE regression
Repository: kafka
Updated Branches:
refs/heads/trunk 85e7a0a2b -> 2a9c18a87
KAFKA-4891; kafka.request.logger TRACE regression
Both the headers and requests have regressed to just show object ids instead of their contents from their underlying structs. I'm guessing this regression came from commit [fc1cfe475e8ae8458d8ddf119ce18d0c64653a70](https://github.com/apache/kafka/commit/fc1cfe475e8ae8458d8ddf119ce18d0c64653a70)
Author: Onur Karaman <ok...@linkedin.com>
Reviewers: Jiangjie Qin <be...@gmail.com>
Closes #2678 from onurkaraman/KAFKA-4891
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/2a9c18a8
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/2a9c18a8
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/2a9c18a8
Branch: refs/heads/trunk
Commit: 2a9c18a87d4374d03f8a07b37a4e66d74325f1c2
Parents: 85e7a0a
Author: Onur Karaman <ok...@linkedin.com>
Authored: Mon Mar 13 13:00:53 2017 -0700
Committer: Jiangjie Qin <be...@gmail.com>
Committed: Mon Mar 13 13:00:53 2017 -0700
----------------------------------------------------------------------
.../java/org/apache/kafka/common/requests/AbstractRequest.java | 5 +++++
.../java/org/apache/kafka/common/requests/RequestHeader.java | 5 +++++
2 files changed, 10 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/2a9c18a8/clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java b/clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
index c2ad39d..3d79f7e 100644
--- a/clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
+++ b/clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java
@@ -79,6 +79,11 @@ public abstract class AbstractRequest extends AbstractRequestResponse {
protected abstract Struct toStruct();
+ @Override
+ public String toString() {
+ return toStruct().toString();
+ }
+
/**
* Get an error response for a request
*/
http://git-wip-us.apache.org/repos/asf/kafka/blob/2a9c18a8/clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java b/clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
index 4b818e7..8a0a549 100644
--- a/clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
+++ b/clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java
@@ -85,4 +85,9 @@ public class RequestHeader extends AbstractRequestResponse {
public static RequestHeader parse(ByteBuffer buffer) {
return new RequestHeader(Protocol.REQUEST_HEADER.read(buffer));
}
+
+ @Override
+ public String toString() {
+ return toStruct().toString();
+ }
}