You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2016/09/22 19:31:41 UTC
Review Request 52172: GEODE-1927: add support for old GemFire remote
sites (WAN)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/
-----------------------------------------------------------
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
Bugs: GEODE-1927
https://issues.apache.org/jira/browse/GEODE-1927
Repository: geode
Description
-------
This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java PRE-CREATION
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
Diff: https://reviews.apache.org/r/52172/diff/
Testing
-------
precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
Thanks,
Bruce Schuchardt
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Dan Smith <ds...@pivotal.io>.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, line 171
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line171>
> >
> > What is this for?
>
> Bruce Schuchardt wrote:
> There's no reason to have JRE jars in the classpath.
ok, makes sense.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java, line 33
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508448#file1508448line33>
> >
> > How is this extensible? This is a static method in a class?
>
> Bruce Schuchardt wrote:
> A jar will go on the server's classpath before geode jars. It will contain an OldClientSupport implementation that will translate the exception to a com.gemstone.gemfire exception for old clients.
Consider using a ServiceProvider instead? It's confusing to have multiple copies of a class on the classpath and rely on one overriding the other, and it can get tricky when you have automated tools building your classpath (gradle, eclipse, intellij, etc.).
Also, it's probably worth thinking about trying to generalize the extension point a little bit more. For example, the version check probably belongs in the extension, not in the product code. Also consider adding unit tests of the extension mechanism in geode.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, line 188
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line188>
> >
> > What is this for?
>
> Bruce Schuchardt wrote:
> This will be used for backward-compatibility testing. It will point to the test output directory so we can find builds of old clients.
Long term, I think we want to separate out the dunit framework from geode so it can be used generically for lots of projects. If possible, we should avoid having a bunch of special case code for specific geode tests in the famework. Rather we should focus on having a generic, extensible framework. Is it possible to pass this test specific property to the child VMs as part of the test itself?
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150072
-----------------------------------------------------------
On Sept. 22, 2016, 7:31 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 7:31 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java, line 33
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508448#file1508448line33>
> >
> > How is this extensible? This is a static method in a class?
A jar will go on the server's classpath before geode jars. It will contain an OldClientSupport implementation that will translate the exception to a com.gemstone.gemfire exception for old clients.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, line 171
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line171>
> >
> > What is this for?
There's no reason to have JRE jars in the classpath.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, line 188
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line188>
> >
> > What is this for?
This will be used for backward-compatibility testing. It will point to the test output directory so we can find builds of old clients.
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150072
-----------------------------------------------------------
On Sept. 22, 2016, 7:31 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 7:31 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On Sept. 22, 2016, 9:07 p.m., Dan Smith wrote:
> > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java, line 188
> > <https://reviews.apache.org/r/52172/diff/1/?file=1508461#file1508461line188>
> >
> > What is this for?
>
> Bruce Schuchardt wrote:
> This will be used for backward-compatibility testing. It will point to the test output directory so we can find builds of old clients.
>
> Dan Smith wrote:
> Long term, I think we want to separate out the dunit framework from geode so it can be used generically for lots of projects. If possible, we should avoid having a bunch of special case code for specific geode tests in the famework. Rather we should focus on having a generic, extensible framework. Is it possible to pass this test specific property to the child VMs as part of the test itself?
The test using this will be migrated to the framework the Jens is working on. We can remove the JTESTS property at that time.
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150072
-----------------------------------------------------------
On Sept. 27, 2016, 11:18 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2016, 11:18 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
> geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
> geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
> geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
> geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
> geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
> geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
> geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
> geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
> geode-old-client-support/build.gradle PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
> geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
> settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150072
-----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java (line 33)
<https://reviews.apache.org/r/52172/#comment217885>
How is this extensible? This is a static method in a class?
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java (line 171)
<https://reviews.apache.org/r/52172/#comment217884>
What is this for?
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java (line 188)
<https://reviews.apache.org/r/52172/#comment217883>
What is this for?
- Dan Smith
On Sept. 22, 2016, 7:31 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2016, 7:31 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupport.java PRE-CREATION
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150748
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Sept. 28, 2016, 4:08 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 4:08 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
> geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
> geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
> geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
> geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
> geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
> geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
> geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
> geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt ecb6529736dd1d31fb3e691552c6b68a38d7d433
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 8ca0b5b34c0428db7561de62982c92bf040e0c64
> geode-old-client-support/build.gradle PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
> geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
> settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150767
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On Sept. 28, 2016, 4:08 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 4:08 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
> geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
> geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
> geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
> geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
> geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
> geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
> geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
> geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt ecb6529736dd1d31fb3e691552c6b68a38d7d433
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 8ca0b5b34c0428db7561de62982c92bf040e0c64
> geode-old-client-support/build.gradle PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
> geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
> settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/#review150770
-----------------------------------------------------------
Ship it!
Ship It!
- Udo Kohlmeyer
On Sept. 28, 2016, 4:08 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52172/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2016, 4:08 p.m.)
>
>
> Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
>
>
> Bugs: GEODE-1927
> https://issues.apache.org/jira/browse/GEODE-1927
>
>
> Repository: geode
>
>
> Description
> -------
>
> This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
>
> I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
>
> The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
>
>
> Diffs
> -----
>
> geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
> geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
> geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
> geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
> geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
> geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
> geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
> geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
> geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
> geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
> geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
> geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt ecb6529736dd1d31fb3e691552c6b68a38d7d433
> geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 8ca0b5b34c0428db7561de62982c92bf040e0c64
> geode-old-client-support/build.gradle PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
> geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
> geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
> geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
> settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
>
> Diff: https://reviews.apache.org/r/52172/diff/
>
>
> Testing
> -------
>
> precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
>
>
> Thanks,
>
> Bruce Schuchardt
>
>
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/
-----------------------------------------------------------
(Updated Sept. 28, 2016, 4:08 p.m.)
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
Changes
-------
precheckin testing showed a number of failures associated with mocked Cache objects. I also found that BaseCommand wasn't correctly replacing the exception it sends to a client with the one returned by OldClientSupportService.
Bugs: GEODE-1927
https://issues.apache.org/jira/browse/GEODE-1927
Repository: geode
Description
-------
This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
Diffs (updated)
-----
geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedDataSerializables.txt ecb6529736dd1d31fb3e691552c6b68a38d7d433
geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt 8ca0b5b34c0428db7561de62982c92bf040e0c64
geode-old-client-support/build.gradle PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
Diff: https://reviews.apache.org/r/52172/diff/
Testing
-------
precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
Thanks,
Bruce Schuchardt
Re: Review Request 52172: GEODE-1927: add support for old GemFire
remote sites (WAN)
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52172/
-----------------------------------------------------------
(Updated Sept. 27, 2016, 11:18 p.m.)
Review request for geode, Hitesh Khamesra and Udo Kohlmeyer.
Changes
-------
Moved most old-client compatibility code to a new subproject, geode-old-client-support. This installs itself as a cache service and also installs itself into InternalDataSerializer, which has a lot of static methods w/o reference to a cache.
Several exception classes were missing serialVersionUIDs and caused integration tests to fail with UID mismatch exceptions. I've added these based on the com.gemstone.gemfire versions of the exceptions for backward compatibility.
The current old-client support assumes that old client JARs will be upgraded to swap the new org.apache.geode package name with com.gemstone.gemfire. Given that, only one class had to be intercepted during serialization and converted to an old class due to its having been renamed (EmtpyRegion -> EmptyRegion).
Tests have been added to cover Java serialization, DataSerializable serialization and PDX serialization for incoming messages from old versions of GemFire. This should also give us the ability to read old diskStores holding serialized com.gemstone.gemfire objects, converting them into org.apache.geode objects.
Bugs: GEODE-1927
https://issues.apache.org/jira/browse/GEODE-1927
Repository: geode
Description
-------
This adds a check in InternalDataSerializer for com.gemstone.gemfire packages and transforms them to org.apache.geode.
I've also added a hook for translating org.apache.geode exceptions into com.gemstone.gemfire exceptions. We've decided to keep com.gemstone.gemfire exceptions out of the Geode repository to avoid the confusion it would cause to have an org.apache.geode implementation throw com.gemstone.gemfire exceptions.
The latter change required changes to some tests using mocks to represent ServerConnections. These mocks were returning null from getClientVersion(), causing NPEs in client/server code.
Diffs (updated)
-----
geode-assembly/build.gradle a83b7a97016836b70a44d80c6a2221f4b4c8a5d9
geode-core/src/main/java/org/apache/geode/CancelException.java 94fd8b556dc04466b7fbae78bc6aaa48d3603c5d
geode-core/src/main/java/org/apache/geode/DataSerializer.java 8e2bad09adef9a6b4e7b5a5a71ff6b97fd515137
geode-core/src/main/java/org/apache/geode/GemFireException.java 142a97c9aa721cea82f7627a24da2517f3f97a24
geode-core/src/main/java/org/apache/geode/cache/CacheException.java 9b631a16b69bef63f9450b3c621764451ea743c4
geode-core/src/main/java/org/apache/geode/cache/CacheRuntimeException.java 9040596635c4ec6177f8e39183ab48025fa74658
geode-core/src/main/java/org/apache/geode/cache/OperationAbortedException.java 340d1844b3d3827b6ff34c08a1ca814fb4c94be9
geode-core/src/main/java/org/apache/geode/cache/RegionExistsException.java 288dfe3c116ab7cd0cd3aec70473ad7c7ac918a8
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java 6e7aa55bd8a8b99c63f39965daa0222f42f64d30
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/BaseCommand.java 9a78772c466996f83383f4e63cb3d1d6654172a0
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/OldClientSupportService.java PRE-CREATION
geode-core/src/main/java/org/apache/geode/internal/cache/wan/BatchException70.java b795156c324f4a0a17a4a0009f5816dec46c8f4c
geode-core/src/main/java/org/apache/geode/pdx/internal/PdxType.java 2e5b19f8b4f2980bb16bf17249ea894fca0652b0
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/ContainsKey66Test.java 6728a377816e521a9419e8dd7576397f8548c14e
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/CreateRegionTest.java 389399191a3a69a1f591d029ecf3ea3981f845db
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Destroy65Test.java ed76cb6a965208b315ebb004cef39ea763d4b686
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyRegionTest.java 49a95a0bdae5f4fb51c0d6fcd8d5513805b45d26
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/DestroyTest.java 422733e4f5e958add74b4b7586bb123703776bc7
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Get70Test.java 4b63a072370746e950ef3697358c7be7a125a213
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/InvalidateTest.java 2dcdd0413c292acd3a9ef40f9809f23f5e95ca29
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put61Test.java c368ba89435303f498a212defdc2508426366093
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put65Test.java 830884c858ae3c6fd4121ed60343e4195b55d77a
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/PutTest.java a9c3af43de1b5b23a958d22b577091e6ccf0bca5
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/RequestTest.java b6997bdef1b51e10780caf1eee6e3a7c46424f98
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/UnregisterInterestTest.java 2da6f19a2708b839264c14b9c27e3ff6702a2b52
geode-core/src/test/java/org/apache/geode/test/dunit/standalone/ProcessManager.java 1c87b1a0346445da95c9d510ecc8b8e6e996bac2
geode-old-client-support/build.gradle PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/GemFireException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/OldClientSupportProvider.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/EmtpyRegionFunctionException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionException.java PRE-CREATION
geode-old-client-support/src/main/java/com/gemstone/gemfire/cache/execute/FunctionInvocationTargetException.java PRE-CREATION
geode-old-client-support/src/main/resources/META-INF/services/org.apache.geode.internal.cache.CacheService PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientDataSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientPDXSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/com/gemstone/gemfire/ClientSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientDataSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientPDXSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/ClientSerializableObject.java PRE-CREATION
geode-old-client-support/src/test/java/org/apache/geode/OldClientSupportDUnitTest.java PRE-CREATION
settings.gradle 95c15f2855d25938e551371b6f93192b7b953fba
Diff: https://reviews.apache.org/r/52172/diff/
Testing
-------
precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo.
Thanks,
Bruce Schuchardt