You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "jerry-024 (via GitHub)" <gi...@apache.org> on 2026/09/09 02:40:30 UTC

[PR] perf(vindex): upload index files with concurrency of 8 [paimon-rust]

jerry-024 opened a new pull request, #798:
URL: https://github.com/apache/paimon-rust/pull/798

   Keep 8 MiB chunks and default FileIO upload concurrency at 1. Add multipart ordering, round-trip, and index build failure coverage.
   
   Validation: formatting and diff checks passed. Runtime tests and benchmarks remain blocked by a Cargo registry connection timeout.
   
   <!--
   Thank you very much for contributing to Paimon Rust - we are happy that you want to help us improve it. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/paimon-rust/issues). Exceptions are made for typos in documentation or comments, which need no issue.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `cargo test` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   <!-- Please describe the changes made in this pull request and explain how they address the issue -->
   
   ### Tests
   
   <!-- List unit tests or integration cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature or require documentation updates -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] perf(vindex): enable 8-way multipart uploads for index files [paimon-rust]

Posted by "jerry-024 (via GitHub)" <gi...@apache.org>.
jerry-024 commented on PR #798:
URL: https://github.com/apache/paimon-rust/pull/798#issuecomment-5596434511

   This PR should remain on hold until paimon-rust can use an official OpenDAL release containing [apache/opendal#8224](https://github.com/apache/opendal/pull/8224) (or an equivalent backport).
   
   The change from concurrency 1 to 8 exposes a memory regression in the currently used OpenDAL implementation. Concurrent task results retain their original retry input, including the upload payload, even after a part succeeds. The multipart writer uses a hard-coded prefetch of 8192, so completed payloads can accumulate while more parts are submitted. Eight concurrent network uploads therefore do not bound retained payloads to eight 8 MiB parts, and large index builds can run out of memory. The previous concurrency-1 path does not accumulate completed inputs this way.
   
   The upstream fix releases successful task inputs before result collection while retaining failed inputs for retry, preserving concurrent uploads. The upstream PR is merged, but merging upstream is not sufficient for this PR: the selected published dependency must actually contain the fix. Once that release is available, update the dependency and verify buffer release, retry correctness, and peak memory during a large 8-way upload before merging.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org