You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2011/06/03 23:45:47 UTC
[jira] [Created] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Improve log levels when exceptions caught in RPC handler
--------------------------------------------------------
Key: HADOOP-7358
URL: https://issues.apache.org/jira/browse/HADOOP-7358
Project: Hadoop Common
Issue Type: Improvement
Components: ipc
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Minor
Fix For: 0.22.0
When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156607#comment-13156607 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Common-22-branch #99 (See [https://builds.apache.org/job/Hadoop-Common-22-branch/99/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205699
Files :
* /hadoop/common/branches/branch-0.22/common/CHANGES.txt
* /hadoop/common/branches/branch-0.22/common/src/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HADOOP-7358:
----------------------------------------
Attachment: HADOOP-7358.trunk.patch
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Uma Maheswara Rao G (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109675#comment-13109675 ]
Uma Maheswara Rao G commented on HADOOP-7358:
---------------------------------------------
Hi Konstantin,
Onbehalf of todd,I have just put the patch for trunk.
Can you please take a look!
Thanks
Uma
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156476#comment-13156476 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1343 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1343/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13189625#comment-13189625 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7358:
------------------------------------------------
> I just committed this to trunk and 0.22 branch. ...
Trunk and 0.22 but not 0.23?
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-7358:
--------------------------------
Attachment: hadoop-7358.txt
Simple patch attached. No test case since it's just a log level change.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156490#comment-13156490 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1393 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1393/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109690#comment-13109690 ]
Hadoop QA commented on HADOOP-7358:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12495404/HADOOP-7358.trunk.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
-1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/215//console
This message is automatically generated.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044082#comment-13044082 ]
Eli Collins commented on HADOOP-7358:
-------------------------------------
+1 pending hudson
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HADOOP-7358:
----------------------------
Status: Patch Available (was: Open)
(Marking as PA since Todd may have forgotten to -- For Hudson)
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156674#comment-13156674 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #873 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/873/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224845#comment-13224845 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Mapreduce-0.23-Commit #664 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/664/])
HADOOP-7358. Merge r1205697 from trunk to 0.23 (Revision 1298207)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1298207
Files :
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156701#comment-13156701 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #907 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/907/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7358:
------------------------------------
Target Version/s: 0.23.1, 0.23.3 (was: 0.23.1)
Fix Version/s: 0.23.3
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0, 0.23.3
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109664#comment-13109664 ]
Konstantin Shvachko commented on HADOOP-7358:
---------------------------------------------
Todd, could you provide a patch for trunk as well.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156488#comment-13156488 ]
Hudson commented on HADOOP-7358:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1320 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1320/])
HADOOP-7358. Improve log levels when exceptions caught in RPC handler. Contributed by Todd Lipcon.
shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1205697
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Eli Collins (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-7358:
--------------------------------
Target Version/s: 0.23.1
Marking for 23.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Konstantin Shvachko (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-7358:
----------------------------------------
Resolution: Fixed
Assignee: Todd Lipcon
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I just committed this to trunk and 0.22 branch. Thank you Todd and Uma.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: HADOOP-7358.trunk.patch, hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7358) Improve log levels when exceptions
caught in RPC handler
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051563#comment-13051563 ]
Hadoop QA commented on HADOOP-7358:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481410/hadoop-7358.txt
against trunk revision 1137065.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/654//console
This message is automatically generated.
> Improve log levels when exceptions caught in RPC handler
> --------------------------------------------------------
>
> Key: HADOOP-7358
> URL: https://issues.apache.org/jira/browse/HADOOP-7358
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Priority: Minor
> Fix For: 0.22.0
>
> Attachments: hadoop-7358.txt
>
>
> When a server implementation throws an exception handling an RPC, the Handler thread catches it and logs it before responding with the exception over the IPC channel. This is currently done at INFO level.
> I'd like to propose that, if the exception is an unchecked exception, it should be logged at WARN level instead. This can help alert operators when they might be hitting some kind of bug.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira