You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/10/01 05:09:36 UTC

[GitHub] [spark] pan3793 commented on a diff in pull request #43189: [SPARK-45388][SQL][HIVE] Eliminate unnecessary reflection invocation in Hive shim classes

pan3793 commented on code in PR #43189:
URL: https://github.com/apache/spark/pull/43189#discussion_r1342076590


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala:
##########
@@ -540,29 +442,25 @@ private[client] class Shim_v2_0 extends Shim with Logging {
           logWarning("Caught Hive MetaException attempting to get partition metadata by " +

Review Comment:
   this is an existing wrong matching rule, which affects 3.3.0 and above, handling in SPARK-45389 (https://github.com/apache/spark/pull/43191).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org