[jira] [Commented] (KAFKA-4774) Inner classes which don't need a reference to the outer class should be static

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870702#comment-15870702 ] 

ASF GitHub Bot commented on KAFKA-4774:
---------------------------------------

GitHub user cmccabe opened a pull request:

    https://github.com/apache/kafka/pull/2558

    KAFKA-4774. Inner classes which don't need a reference to the outer c…

    …lass should be static

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cmccabe/kafka KAFKA-4774

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2558.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2558
    
----
commit a44130af1cbb2ba0ac57c32bc9ab5d5e238896c3
Author: Colin P. Mccabe <cm...@confluent.io>
Date:   2017-02-16T21:06:53Z

    KAFKA-4774. Inner classes which don't need a reference to the outer class should be static

----


> Inner classes which don't need a reference to the outer class should be static
> ------------------------------------------------------------------------------
>
>                 Key: KAFKA-4774
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4774
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Colin P. McCabe
>            Assignee: Colin P. McCabe
>
> Inner classes which don't need a reference to the outer class should be static.  This takes up less space in memory, generates less load on the garbage collector, and eliminates a findbugs warning.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)