You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@parquet.apache.org by we...@apache.org on 2017/04/02 16:11:20 UTC
parquet-cpp git commit: PARQUET-943: Fix build error on x86
Repository: parquet-cpp
Updated Branches:
refs/heads/master 286d75f9a -> a5bcc38a4
PARQUET-943: Fix build error on x86
"L" is small on x86:
src/parquet/arrow/reader.cc:52:55: warning: integer overflow in expression [-Woverflow]
constexpr int64_t kNanosecondsInADay = 86400L * 1000L * 1000L * 1000L;
^
src/parquet/arrow/reader.cc:52:65: error: overflow in constant expression [-fpermissive]
constexpr int64_t kNanosecondsInADay = 86400L * 1000L * 1000L * 1000L;
^
src/parquet/arrow/reader.cc: In function 'int64_t parquet::arrow::impala_timestamp_to_nanoseconds(const parquet::Int96&)':
src/parquet/arrow/reader.cc:58:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
Author: Kouhei Sutou <ko...@clear-code.com>
Closes #289 from kou/fix-build-error-on-x86 and squashes the following commits:
055e226 [Kouhei Sutou] Fix build error on x86
Project: http://git-wip-us.apache.org/repos/asf/parquet-cpp/repo
Commit: http://git-wip-us.apache.org/repos/asf/parquet-cpp/commit/a5bcc38a
Tree: http://git-wip-us.apache.org/repos/asf/parquet-cpp/tree/a5bcc38a
Diff: http://git-wip-us.apache.org/repos/asf/parquet-cpp/diff/a5bcc38a
Branch: refs/heads/master
Commit: a5bcc38a40c2cfff5987d1fec65a99085a73abd2
Parents: 286d75f
Author: Kouhei Sutou <ko...@clear-code.com>
Authored: Sun Apr 2 12:11:14 2017 -0400
Committer: Wes McKinney <we...@twosigma.com>
Committed: Sun Apr 2 12:11:14 2017 -0400
----------------------------------------------------------------------
src/parquet/arrow/reader.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/parquet-cpp/blob/a5bcc38a/src/parquet/arrow/reader.cc
----------------------------------------------------------------------
diff --git a/src/parquet/arrow/reader.cc b/src/parquet/arrow/reader.cc
index 53600b4..a26c3ea 100644
--- a/src/parquet/arrow/reader.cc
+++ b/src/parquet/arrow/reader.cc
@@ -48,8 +48,8 @@ using ParquetReader = parquet::ParquetFileReader;
namespace parquet {
namespace arrow {
-constexpr int64_t kJulianToUnixEpochDays = 2440588L;
-constexpr int64_t kNanosecondsInADay = 86400L * 1000L * 1000L * 1000L;
+constexpr int64_t kJulianToUnixEpochDays = 2440588LL;
+constexpr int64_t kNanosecondsInADay = 86400LL * 1000LL * 1000LL * 1000LL;
static inline int64_t impala_timestamp_to_nanoseconds(const Int96& impala_timestamp) {
int64_t days_since_epoch = impala_timestamp.value[2] - kJulianToUnixEpochDays;