You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by macdonst <gi...@git.apache.org> on 2017/07/25 03:55:56 UTC
[GitHub] cordova-android pull request #399: CB-12730: Compat - INTEGRATE
GitHub user macdonst opened a pull request:
https://github.com/apache/cordova-android/pull/399
CB-12730: Compat - INTEGRATE
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
This PR integrates cordova-plugin-compat directly into cordova-android. Going forward you will not need to add this plugin to your project.
### What testing has been done on this change?
Created a new cordova-android project using this branch. Added a custom version of barcode scanner that does not depend on cordova-plugin-compat. When the app runs the permission dialog is displayed properly when I request to scan a barcode and it allows access to the camera when I allow the permission.
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/macdonst/cordova-android CB-12730
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit 0e0062c4453adeed7233e2550de933555c0e3315
Author: Simon MacDonald <si...@gmail.com>
Date: 2017-07-25T03:40:01Z
CB-12730: Compat - INTEGRATE
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/399
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=h1) Report
> Merging [#399](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/2b53c98cf585a2f82f9d94f9acc210f362c48f97?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 42.55% 42.55%
=======================================
Files 17 17
Lines 1678 1678
Branches 304 304
=======================================
Hits 714 714
Misses 964 964
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=footer). Last update [2b53c98...d364f46](https://codecov.io/gh/apache/cordova-android/pull/399?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by macdonst <gi...@git.apache.org>.
Github user macdonst commented on the issue:
https://github.com/apache/cordova-android/pull/399
@filmaj rebased and pushed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/399
@filmaj Another being this article https://medium.com/exploring-android/handling-android-runtime-permissions-in-ui-tests-981f9dc11a4e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
Well glad that cleared up the CI failures.
Should we add unit, or instrumentation, native tests for this?
Also ping @infil00p for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
One example: [this repo](https://github.com/Egorand/android-testing-runtime-permissions)'s [main test file](https://github.com/Egorand/android-testing-runtime-permissions/blob/master/app/src/androidTest/java/me/egorand/contactssync/tests/ContactsSyncTest.java) asserts that certain text is visible (like "Allow" and "Deny") when triggering the permissions dialog (via Contacts usage), and also asserts the behaviour of returning contact data if the permission is accepted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
Hey @macdonst if you rebase w/ latest master, I think we can clear up the appveyor failure we're seeing in here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #399: CB-12730: Compat - INTEGRATE
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/399
We should add some instrumentation native tests for this, but I have no idea how that would work, and would have to do more research into this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org