You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/01 06:56:28 UTC
[GitHub] [airflow] evanrosebrook opened a new pull request #22676: Fix helm name override
evanrosebrook opened a new pull request #22676:
URL: https://github.com/apache/airflow/pull/22676
This change completes the work required to allow nameOverride and fullnameOverride to function as expected. Kubernetes objects will now be created in a manner consistent with current helm conventions.
Objects created with fullnameOverride specified will use the fullnameOverride to create object names.
If nameOverride is specified the value of nameOverride is combined with the chart name to create object names.
If nameOverride and fullnameOverride are both specified then fullnameOverride will take precedence.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22676: Fix helm name override
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22676:
URL: https://github.com/apache/airflow/pull/22676#issuecomment-1086122774
> Within the deployment itself it is not breaking. However, if teams have built external monitoring that expects specific names that were changed, it could mess with that.
Yep. That exactly what I mean :). We **might** not care about it as it is an internal detail. Or treat it as bugfix ("shoudl work like that always"). I am leaning towards the latter, but I will leave it to others to comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22676: Fix helm name override
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #22676:
URL: https://github.com/apache/airflow/pull/22676#issuecomment-1085502410
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #22676: Fix helm name override
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #22676:
URL: https://github.com/apache/airflow/pull/22676#issuecomment-1086122774
> Within the deployment itself it is not breaking. However, if teams have built external monitoring that expects specific names that were changed, it could mess with that.
Yep. That exactly what I mean :). We **might** not care about it as it is an internal detail. Or treat it as bugfix ("should work like that always"). I am leaning towards the latter, but I will leave it to others to comment :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22676: Fix helm name override
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22676:
URL: https://github.com/apache/airflow/pull/22676#issuecomment-1085987486
While I think it is good, it seems like a potentially breaking change? I am not sure if this is a problem though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] evanrosebrook commented on pull request #22676: Fix helm name override
Posted by GitBox <gi...@apache.org>.
evanrosebrook commented on pull request #22676:
URL: https://github.com/apache/airflow/pull/22676#issuecomment-1086044866
Within the deployment itself it is not breaking. However, if teams have built external monitoring that expects specific names that were changed, it could mess with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org