[jira] [Commented] (HIVE-18668) Druid tests fail with shaded guava(?)

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395115#comment-16395115 ] 

Zoltan Haindrich commented on HIVE-18668:
-----------------------------------------

[~sershe] you've reverted the patch; It would be great if you would asked before doing it.

{code}
unzip -t ~/.m2/active_repository/com/google/guava/guava/19.0/guava-19.0.jar|grep com/google/guava
< no results >
{code}

actually what you see is that "Stopwatch" is not shaded at all if you remove this patch - which is clearly bad ....
because the guava libs are at "com.google.common" ; and there are no classes under com.google.guava....shading ensures that the classes actually used by the code will be there at a different location; If you are looking for "Stopwatch" which is never even used from ql....

> Druid tests fail with shaded guava(?)
> -------------------------------------
>
>                 Key: HIVE-18668
>                 URL: https://issues.apache.org/jira/browse/HIVE-18668
>             Project: Hive
>          Issue Type: Bug
>          Components: Druid integration
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18668.01.patch
>
>
> After HIVE-15393 a test started to fail in druid; after some investigation it turned out that ql doesn't shade it's guava artifact at all...because it shades 'com.google.guava' instead 'com.google.common'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)