[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #14538: [numpy] Fix test_dynamic_shape.test_dynamic_shape

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #14538: [numpy] Fix test_dynamic_shape.test_dynamic_shape
URL: https://github.com/apache/incubator-mxnet/pull/14538#discussion_r269352649
 
 

 ##########
 File path: src/imperative/imperative_utils.cc
 ##########
 @@ -186,7 +186,7 @@ void NaiveRunGraph(
       Imperative::Get()->InvokeOp(ctx, node.source->attrs, ndinputs, ndoutputs,
                                   req, dispatch_mode, state);
       for (size_t j = 0; j < ndoutputs.size(); ++j) {
-        if (ndoutputs[j]->shape().ndim() == 0) {
+        if (ndoutputs[j]->shape().ndim() == -1) {
 
 Review comment:
   nit: Better to use `shape_is_known` for readability. More precisely, it should be `shape_is_known` instead of just `ndim_is_known`, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services