You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/11 06:40:26 UTC

[GitHub] [apisix] spacewander opened a new pull request #2704: fix: reload plugin when plugin attribute is cahnged

spacewander opened a new pull request #2704:
URL: https://github.com/apache/apisix/pull/2704


   Close #2655
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [x] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2704: fix: reload plugin when plugin attribute is changed

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2704:
URL: https://github.com/apache/apisix/pull/2704#discussion_r522174734



##########
File path: apisix/plugin.lua
##########
@@ -51,6 +51,14 @@ local _M = {
 }
 
 
+local function plugin_attr(name)
+    -- TODO: get attr from synchronized data

Review comment:
       Is this TODO related to this PR?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan merged pull request #2704: fix: reload plugin when plugin attribute is changed

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2704:
URL: https://github.com/apache/apisix/pull/2704


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org