You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/11/21 12:20:36 UTC
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #35: use org.apache.pekko as org id
mdedetrich commented on code in PR #35:
URL: https://github.com/apache/incubator-pekko/pull/35#discussion_r1027946013
##########
akka-docs/src/main/paradox/actors.md:
##########
@@ -7,13 +7,13 @@
To use Classic Actors, add the following dependency in your project:
@@dependency[sbt,Maven,Gradle] {
- bomGroup=com.typesafe.akka bomArtifact=akka-bom_$scala.binary.version$ bomVersionSymbols=AkkaVersion
+ bomGroup=org.apache.pekko bomArtifact=akka-bom_$scala.binary.version$ bomVersionSymbols=AkkaVersion
symbol1=AkkaVersion
value1="$akka.version$"
- group="com.typesafe.akka"
+ group="org.apache.pekko"
artifact="akka-actor_$scala.binary.version$"
version=AkkaVersion
- group2="com.typesafe.akka"
+ group2="org.apache.pekko"
Review Comment:
After working on my PR regarding renaming the package, I kind of under-estimated the scope that some of these changes require. I have come to the conclusion that we might have to deal with some massive PR's, at least if we want to uphold the "no PR shall break CI build" (which I think there isn't any argument against).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org