You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by "Kamal Bhatt (JIRA)" <ji...@apache.org> on 2008/04/27 14:12:55 UTC
[jira] Created: (COCOON-2204) [PATCH]
[PATCH]
--------
Key: COCOON-2204
URL: https://issues.apache.org/jira/browse/COCOON-2204
Project: Cocoon
Issue Type: Bug
Components: Blocks: Forms
Affects Versions: 2.2, 2.2-dev (Current SVN)
Reporter: Kamal Bhatt
Fix For: 2.2-dev (Current SVN)
According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
<ft:group id="info">
<div>
<p><ft:widget id="foo"/></p>
<p><ft:widget id="bar"/></p>
</div>
</ft:group>
CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
NOTE: This is another solution to the problem described here:
https://issues.apache.org/jira/browse/COCOON-1825
However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
Patch is provided below:
Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
===================================================================
--- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
+++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
@@ -706,7 +706,7 @@
<xsl:apply-templates/>
</xsl:template>
- <xsl:template match="fi:group" mode="copy-parent-id">
+ <xsl:template match="*" mode="copy-parent-id">
<xsl:copy>
<xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
<xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592700#action_12592700 ]
Jörg Heinicke commented on COCOON-2204:
---------------------------------------
Confirming the bug ... it does not exist in 2.1. No idea how/when it was introduced/fixed. The stylesheet is completely out of sync in 2.1 and 2.2.
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Heinicke closed COCOON-2204.
---------------------------------
Resolution: Fixed
Affects version (Component): Parent values: Blocks: Forms(10167). Level 1 values: 1.0.0-RC3-SNAPSHOT(10331). (was: Parent values: Blocks: Forms(10167). Level 1 values: 1.0.0-RC2(10330). )
Fix version (Component): Parent values: Blocks: Forms(10239). (was: Parent values: Blocks: Forms(10239). Level 1 values: 1.0.0-RC2(10332). )
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Kamal Bhatt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592684#action_12592684 ]
Kamal Bhatt commented on COCOON-2204:
-------------------------------------
{quote}
Is there still any documentation out there in which we say to prefix summary with [PATCH]? We have the "Patch available" check box now which is sufficient.
{quote}
Probably not. Case of Monkey see, Monkey do.
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Kamal Bhatt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592718#action_12592718 ]
Kamal Bhatt commented on COCOON-2204:
-------------------------------------
Thanks.
Am I correct in saying that this issue:
https://issues.apache.org/jira/browse/COCOON-1825
Is redundant?
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Priority: Minor
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2204) [PATCH] ft:group internal div not
handled correctly.
Posted by "Kamal Bhatt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kamal Bhatt updated COCOON-2204:
--------------------------------
Summary: [PATCH] ft:group internal div not handled correctly. (was: [PATCH] )
Changed title to something more descriptive than just [PATCH].
> [PATCH] ft:group internal div not handled correctly.
> ----------------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Heinicke reassigned COCOON-2204:
-------------------------------------
Assignee: Jörg Heinicke
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Heinicke updated COCOON-2204:
----------------------------------
Priority: Minor (was: Major)
Urgency: Normal (was: Urgent)
Affects Version/s: (was: 2.2-dev (Current SVN))
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Priority: Minor
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jörg Heinicke updated COCOON-2204:
----------------------------------
Summary: ft:group internal div not handled correctly. (was: [PATCH] ft:group internal div not handled correctly.)
Is there still any documentation out there in which we say to prefix summary with [PATCH]? We have the "Patch available" check box now which is sufficient.
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COCOON-2204) ft:group internal div not handled
correctly.
Posted by "Jörg Heinicke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592727#action_12592727 ]
Jörg Heinicke commented on COCOON-2204:
---------------------------------------
The fi:struct part was still missing. Applied now as well.
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2
> Reporter: Kamal Bhatt
> Assignee: Jörg Heinicke
> Priority: Minor
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (COCOON-2204) ft:group internal div
not handled correctly.
Posted by "Kamal Bhatt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COCOON-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592684#action_12592684 ]
kambha edited comment on COCOON-2204 at 4/27/08 3:07 PM:
--------------------------------------------------------------
Quote: Is there still any documentation out there in which we say to prefix summary with [PATCH]? We have the "Patch available" check box now which is sufficient.
Probably not. Case of Monkey see, Monkey do.
was (Author: kambha):
{quote}
Is there still any documentation out there in which we say to prefix summary with [PATCH]? We have the "Patch available" check box now which is sufficient.
{quote}
Probably not. Case of Monkey see, Monkey do.
> ft:group internal div not handled correctly.
> --------------------------------------------
>
> Key: COCOON-2204
> URL: https://issues.apache.org/jira/browse/COCOON-2204
> Project: Cocoon
> Issue Type: Bug
> Components: Blocks: Forms
> Affects Versions: 2.2, 2.2-dev (Current SVN)
> Reporter: Kamal Bhatt
> Fix For: 2.2-dev (Current SVN)
>
>
> According to this page: http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html
> If you you are using Ajax, a div (or similar element) must surround the fields of a group. eg:
> <ft:group id="info">
> <div>
> <p><ft:widget id="foo"/></p>
> <p><ft:widget id="bar"/></p>
> </div>
> </ft:group>
> CForms (through the magic of the forms-field-styling.xsl) will put the group's id on the div. The code to this, seems broken as it does not match on the div, but on the fi:group.
> NOTE: This is another solution to the problem described here:
> https://issues.apache.org/jira/browse/COCOON-1825
> However, the solution described within it seems to make the suggestion in http://cocoon.apache.org/2.2/blocks/forms/1.0/750_1_1.html redundant. Either way, either this issue or that one is not necessary.
> Patch is provided below:
> Index: D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl
> ===================================================================
> --- D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (revision 651922)
> +++ D:/workspace-java/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/forms-field-styling.xsl (working copy)
> @@ -706,7 +706,7 @@
> <xsl:apply-templates/>
> </xsl:template>
>
> - <xsl:template match="fi:group" mode="copy-parent-id">
> + <xsl:template match="*" mode="copy-parent-id">
> <xsl:copy>
> <xsl:attribute name="id"><xsl:value-of select="../@id"/></xsl:attribute>
> <xsl:copy-of select="@*"/>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.