You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "michael-o (via GitHub)" <gi...@apache.org> on 2024/05/14 07:20:15 UTC
[PR] [DAEMON-464] struct sigaction function pointer causes build failures … [commons-daemon]
michael-o opened a new pull request, #170:
URL: https://github.com/apache/commons-daemon/pull/170
…on LLVM 15+
Co-authored-by: Matthew Ryan <ma...@akamai.com>
This closes #166 and #170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DAEMON-464] struct sigaction function pointer causes build failures … [commons-daemon]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #170: [DAEMON-464] struct sigaction function pointer causes build failures …
URL: https://github.com/apache/commons-daemon/pull/170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DAEMON-464] struct sigaction function pointer causes build failures … [commons-daemon]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #170:
URL: https://github.com/apache/commons-daemon/pull/170#issuecomment-2111947729
The changes to handler are unnecessary. It is valid (as per man sigaction on a system where the compilation currently fails) to use `sa_handler` when the handling function takes the signal number as its only argument. Also, switching to `sa_sigaction` requires the addition of the `SA_SIGINFO` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DAEMON-464] struct sigaction function pointer causes build failures … [commons-daemon]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #170:
URL: https://github.com/apache/commons-daemon/pull/170#issuecomment-2109512437
Works for me on:
* cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-44)
* FreeBSD clang version 17.0.6 (https://github.com/llvm/llvm-project.git llvmorg-17.0.6-0-g6009708b4367)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org