You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2008/08/06 20:24:44 UTC
[jira] Created: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
------------------------------------------------------------------------
Key: HADOOP-3910
URL: https://issues.apache.org/jira/browse/HADOOP-3910
Project: Hadoop Core
Issue Type: Bug
Components: dfs, test
Reporter: Tsz Wo (Nicholas), SZE
Priority: Minor
ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625801#action_12625801 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-3910:
------------------------------------------------
It should not be anyone using ClusterTestDFS since trunk currently fails on it. For ClusterTestDFSNamespaceLogging, I guess probably also no one using it.
How about we deprecated them and then we can remove them later?
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3910:
-------------------------------------------
Attachment: 3910_20080827.patch
3910_20080827.patch: deprecated the tests
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3910_20080827.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3910:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks Nicholas
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 3910_20080827.patch, 3910_20080828.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3910:
-------------------------------------------
Assignee: Tsz Wo (Nicholas), SZE
Status: Patch Available (was: Open)
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3910_20080827.patch, 3910_20080828.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626616#action_12626616 ]
Doug Cutting commented on HADOOP-3910:
--------------------------------------
No need to deprecate them. They can simply be removed. They're in the test tree and are hence not in javadoc nor in the primary hadoop jar.
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3910_20080827.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624128#action_12624128 ]
Doug Cutting commented on HADOOP-3910:
--------------------------------------
As I recall these were not written as unit tests, but as tests that would only be run on larger clusters. But if no one uses them, then they should probably be removed.
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-3910:
-------------------------------------------
Attachment: 3910_20080828.patch
3910_20080828.patch: removed ClusterTestDFSNamespaceLogging and ClusterTestDFS.
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3910_20080827.patch, 3910_20080828.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626828#action_12626828 ]
Hadoop QA commented on HADOOP-3910:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12389121/3910_20080828.patch
against trunk revision 690020.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3139/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3139/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3139/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3139/console
This message is automatically generated.
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: 3910_20080827.patch, 3910_20080828.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3910) Are ClusterTestDFSNamespaceLogging
and ClusterTestDFS still valid tests?
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627652#action_12627652 ]
Hudson commented on HADOOP-3910:
--------------------------------
Integrated in Hadoop-trunk #590 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/590/])
> Are ClusterTestDFSNamespaceLogging and ClusterTestDFS still valid tests?
> ------------------------------------------------------------------------
>
> Key: HADOOP-3910
> URL: https://issues.apache.org/jira/browse/HADOOP-3910
> Project: Hadoop Core
> Issue Type: Bug
> Components: dfs, test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: 3910_20080827.patch, 3910_20080828.patch
>
>
> ClusterTestDFSNamespaceLogging and ClusterTestDFS are not executed by "ant test" since their names do not begin with "Test". So these two tests have not be run for a long time.
> I ran these two tests manually. Trunk passed ClusterTestDFSNamespaceLogging but failed on ClusterTestDFS. I am not sure whether they are still valid tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.