You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/03/27 08:29:59 UTC
Review Request 32565: SQOOP-2094: Update RESTAPI.rst
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
As new Rest API is added, the description should be added in RESTAPI.rst
Diffs
-----
docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
Diff: https://reviews.apache.org/r/32565/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by richard zhou <ri...@intel.com>.
> On March 27, 2015, 11:39 p.m., Abraham Elmahrek wrote:
> > Hmm I tried to build this, but I get a lot of error messages on RESTAPI.html. See Jira for pic.
I have fixed the "title underline too short" issue. But I am not sure whether there is any other grammar error in this rst file. I do not have any tools to check the rst file grammar.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/#review78129
-----------------------------------------------------------
On March 30, 2015, 6:27 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32565/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 6:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> As new Rest API is added, the description should be added in RESTAPI.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
>
> Diff: https://reviews.apache.org/r/32565/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by richard zhou <ri...@intel.com>.
> On March 27, 2015, 11:39 p.m., Abraham Elmahrek wrote:
> > Hmm I tried to build this, but I get a lot of error messages on RESTAPI.html. See Jira for pic.
>
> richard zhou wrote:
> I have fixed the "title underline too short" issue. But I am not sure whether there is any other grammar error in this rst file. I do not have any tools to check the rst file grammar.
I have fixed all grammars. Please help to check. Thanks.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/#review78129
-----------------------------------------------------------
On March 30, 2015, 6:52 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32565/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 6:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> As new Rest API is added, the description should be added in RESTAPI.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
>
> Diff: https://reviews.apache.org/r/32565/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/#review78129
-----------------------------------------------------------
Hmm I tried to build this, but I get a lot of error messages on RESTAPI.html. See Jira for pic.
- Abraham Elmahrek
On March 27, 2015, 7:29 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32565/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> As new Rest API is added, the description should be added in RESTAPI.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
>
> Diff: https://reviews.apache.org/r/32565/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/#review78238
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 30, 2015, 6:52 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32565/
> -----------------------------------------------------------
>
> (Updated March 30, 2015, 6:52 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> As new Rest API is added, the description should be added in RESTAPI.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
>
> Diff: https://reviews.apache.org/r/32565/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/
-----------------------------------------------------------
(Updated March 30, 2015, 6:52 a.m.)
Review request for Sqoop.
Changes
-------
Fixed all grammar issue.
Repository: sqoop-sqoop2
Description
-------
As new Rest API is added, the description should be added in RESTAPI.rst
Diffs (updated)
-----
docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
Diff: https://reviews.apache.org/r/32565/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/
-----------------------------------------------------------
(Updated March 30, 2015, 6:27 a.m.)
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
As new Rest API is added, the description should be added in RESTAPI.rst
Diffs (updated)
-----
docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
Diff: https://reviews.apache.org/r/32565/diff/
Testing
-------
Thanks,
richard zhou
Re: Review Request 32565: SQOOP-2094: Update RESTAPI.rst
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32565/#review78119
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On March 27, 2015, 7:29 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32565/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:29 a.m.)
>
>
> Review request for Sqoop.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> As new Rest API is added, the description should be added in RESTAPI.rst
>
>
> Diffs
> -----
>
> docs/src/site/sphinx/RESTAPI.rst fa23b42533650dbc2541681bc8a17ed535696a19
>
> Diff: https://reviews.apache.org/r/32565/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> richard zhou
>
>