You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/21 14:07:46 UTC

[GitHub] [flink-statefun] igalshilman opened a new pull request #190: [FLINK-20699] Set FeedbackKey invocation_id explicitly

igalshilman opened a new pull request #190:
URL: https://github.com/apache/flink-statefun/pull/190


   ###  This PR sets the invocation id part of a `FeedbackKey` explicitly, both in the data stream integration API and the embedded API.
   
   Currently the operators that obtain a `FeedbackChannel` via a `FeedbackKey` are also closing it, on their `dispose` and `close` methods. Setting an invocation_id explicitly every time a `FeedbackKey` is created, reduces the risk of accidentally sharing the same `FeedbackChannel` across invocations.
   
   ### Verifying the change
   * run e2e test
   * run  `org.apache.flink.statefun.e2e.smoke.Harness` in a loop.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] tzulitai closed pull request #190: [FLINK-20699] Set FeedbackKey invocation_id explicitly

Posted by GitBox <gi...@apache.org>.
tzulitai closed pull request #190:
URL: https://github.com/apache/flink-statefun/pull/190


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-statefun] tzulitai commented on pull request #190: [FLINK-20699] Set FeedbackKey invocation_id explicitly

Posted by GitBox <gi...@apache.org>.
tzulitai commented on pull request #190:
URL: https://github.com/apache/flink-statefun/pull/190#issuecomment-749343443


   Thanks @igalshilman, +1 LGTM. Merging this ...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org