You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2015/11/19 03:37:22 UTC

Review Request 40467: HIVE-12075 analyze for file metadata

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/
-----------------------------------------------------------

Review request for hive, Alan Gates and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85 
  itests/src/test/resources/testconfiguration.properties a33e720 
  llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1d0fdf0 
  metastore/if/hive_metastore.thrift bb754f1 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a835f6a 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 02cbd76 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 803c6e7 
  metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 
  metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af 
  metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9ab3e98 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java f9978b4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 543bc0f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eea2fcc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e9fbfb1 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 009e72e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
  ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
  ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/40467/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 40467: HIVE-12075 analyze for file metadata

Posted by Sergey Shelukhin <se...@hortonworks.com>.

> On Nov. 19, 2015, 11:51 p.m., Alan Gates wrote:
> > metastore/if/hive_metastore.thrift, line 781
> > <https://reviews.apache.org/r/40467/diff/1/?file=1131717#file1131717line781>
> >
> >     You allow it to request caching for one partition or all.  Are there cases where you'd want to cache some put not all partitions?  Should partName be list instead?

There is no syntax in Hive to support this now (analyze takes either a table or one partition), we can add it later if needed.


> On Nov. 19, 2015, 11:51 p.m., Alan Gates wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java, line 111
> > <https://reviews.apache.org/r/40467/diff/1/?file=1131719#file1131719line111>
> >
> >     Is this going to work with ACID?  There's an extra level of directories there for base and delta.

yes, the HDFS call is recursive


> On Nov. 19, 2015, 11:51 p.m., Alan Gates wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java, line 73
> > <https://reviews.apache.org/r/40467/diff/1/?file=1131725#file1131725line73>
> >
> >     Why did you make these methods ORC specific?  That doesn't seem appropriate this level.  What's to keep Parquet or another format from supporting file metadata?

if they want to, they'd need to implement their own methods. The contents of the buffer are format-specific because they are stored by a format handler.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/#review107267
-----------------------------------------------------------


On Nov. 19, 2015, 2:37 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40467/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 2:37 a.m.)
> 
> 
> Review request for hive, Alan Gates and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85 
>   itests/src/test/resources/testconfiguration.properties a33e720 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1d0fdf0 
>   metastore/if/hive_metastore.thrift bb754f1 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a835f6a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 02cbd76 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 803c6e7 
>   metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 
>   metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af 
>   metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9ab3e98 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java f9978b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 543bc0f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eea2fcc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e9fbfb1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 009e72e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
>   ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 40467: HIVE-12075 analyze for file metadata

Posted by Alan Gates <ga...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/#review107267
-----------------------------------------------------------



metastore/if/hive_metastore.thrift (line 781)
<https://reviews.apache.org/r/40467/#comment166294>

    You allow it to request caching for one partition or all.  Are there cases where you'd want to cache some put not all partitions?  Should partName be list instead?



metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java (line 45)
<https://reviews.apache.org/r/40467/#comment166296>

    I agree with this not depending on HBaseReadWrite.  conceptually ObjectStore could choose to implement file metadata caching.  There's nothing HBase specific about it.  And HBaseReadWrite was not intended to be used outside of the metastore/hbase package.



metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java (line 111)
<https://reviews.apache.org/r/40467/#comment166297>

    Is this going to work with ACID?  There's an extra level of directories there for base and delta.



metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java (line 73)
<https://reviews.apache.org/r/40467/#comment166300>

    Why did you make these methods ORC specific?  That doesn't seem appropriate this level.  What's to keep Parquet or another format from supporting file metadata?



metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java (line 81)
<https://reviews.apache.org/r/40467/#comment166305>

    PartitionExpressionForMetastore implements PartitionExpressionProxy.  But I don't see any changes for that class in this patch.  Did it just fall out when you removed the generated code?



metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java (line 2149)
<https://reviews.apache.org/r/40467/#comment166302>

    Nitpick:  data is already plural, so "metadatas" is weird.  I know we never talk about metadatum, but still...



metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java (line 2150)
<https://reviews.apache.org/r/40467/#comment166303>

    I don't understand what's in the addedCols and addedVals arrays.


- Alan Gates


On Nov. 19, 2015, 2:37 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40467/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 2:37 a.m.)
> 
> 
> Review request for hive, Alan Gates and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 2185f85 
>   itests/src/test/resources/testconfiguration.properties a33e720 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1d0fdf0 
>   metastore/if/hive_metastore.thrift bb754f1 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a835f6a 
>   metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
>   metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 02cbd76 
>   metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 803c6e7 
>   metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
>   metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 
>   metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f 
>   metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 
>   metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af 
>   metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
>   metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
>   metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9ab3e98 
>   ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java f9978b4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 543bc0f 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eea2fcc 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g e9fbfb1 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 009e72e 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
>   ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
>   shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40467/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Re: Review Request 40467: HIVE-12075 analyze for file metadata

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 4:17 a.m.)


Review request for hive, Alan Gates and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 243f281 
  itests/src/test/resources/testconfiguration.properties 1e7dce3 
  metastore/if/hive_metastore.thrift bb754f1 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0940fd7 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 23068f8 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java abfe2b8 
  metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e118a3b 
  metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 287394e 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java b9509ab 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/MetadataStore.java PRE-CREATION 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java c1156b3 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java bf20e99 
  metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4fb6c00 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c682df2 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java 7cddcc9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 832a5bc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c407aae 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1c72b1c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d5051ce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
  ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
  ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/40467/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 40467: HIVE-12075 analyze for file metadata

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/
-----------------------------------------------------------

(Updated Dec. 16, 2015, 4:12 a.m.)


Review request for hive, Alan Gates and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 243f281 
  itests/src/test/resources/testconfiguration.properties 1e7dce3 
  metastore/if/hive_metastore.thrift bb754f1 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileFormatProxy.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 0940fd7 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 23068f8 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java abfe2b8 
  metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e118a3b 
  metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/FileMetadataHandler1.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 287394e 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java b9509ab 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/MetadataStore.java PRE-CREATION 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java c1156b3 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java bf20e99 
  metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 4fb6c00 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcFileFormatProxy.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c682df2 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java 7cddcc9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 832a5bc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java c407aae 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 1c72b1c 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g d5051ce 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
  ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
  ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/40467/diff/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 40467: HIVE-12075 analyze for file metadata

Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40467/
-----------------------------------------------------------

(Updated Nov. 26, 2015, 2:13 a.m.)


Review request for hive, Alan Gates and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java db942b0 
  itests/src/test/resources/testconfiguration.properties 0c5140c 
  llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 1d0fdf0 
  metastore/if/hive_metastore.thrift bb754f1 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataHandler.java 7c3525a 
  metastore/src/java/org/apache/hadoop/hive/metastore/FileMetadataManager.java PRE-CREATION 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a835f6a 
  metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c5e7a5f 
  metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java aa96f77 
  metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java 02cbd76 
  metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 803c6e7 
  metastore/src/java/org/apache/hadoop/hive/metastore/PartitionExpressionProxy.java ed59829 
  metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java 5b36b03 
  metastore/src/java/org/apache/hadoop/hive/metastore/filemeta/OrcFileMetadataHandler.java 14189da 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseReadWrite.java 2fb3e8f 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseStore.java 98e6c75 
  metastore/src/java/org/apache/hadoop/hive/metastore/hbase/MetadataStore.java PRE-CREATION 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java 9a1d159 
  metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 8dde0af 
  metastore/src/test/org/apache/hadoop/hive/metastore/MockPartitionExpressionForMetastore.java d72bf76 
  metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 9089d1c 
  metastore/src/test/org/apache/hadoop/hive/metastore/hbase/MockUtils.java 983129a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a210b95 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 488d923 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java f9978b4 
  ql/src/java/org/apache/hadoop/hive/ql/parse/AnalyzeCommandUtils.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 832a5bc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java eea2fcc 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 395152f 
  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 009e72e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 0affe84 
  ql/src/java/org/apache/hadoop/hive/ql/plan/CacheMetadataDesc.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java a4c3db1 
  ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java af7e43e 
  ql/src/test/queries/clientpositive/stats_filemetadata.q PRE-CREATION 
  ql/src/test/results/clientpositive/tez/stats_filemetadata.q.out PRE-CREATION 
  shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/40467/diff/


Testing
-------


Thanks,

Sergey Shelukhin