You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/23 18:27:49 UTC
[GitHub] [incubator-superset] mistercrunch commented on issue #8280:
[superset] Core SQLAlchemy query refactor
mistercrunch commented on issue #8280: [superset] Core SQLAlchemy query refactor
URL: https://github.com/apache/incubator-superset/pull/8280#issuecomment-534224918
replacing `.first()` with `.get()` when filtering on pk seems right. But `.one()` is different as it will raise if nothing matches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org