You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "chia7712 (via GitHub)" <gi...@apache.org> on 2024/07/29 15:45:23 UTC

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

chia7712 commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1695461084


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -568,7 +570,11 @@ public void transitionToFenced() {
     public void transitionToFatal() {
         MemberState previousState = state;
         transitionTo(MemberState.FATAL);
-        log.error("Member {} with epoch {} transitioned to {} state", memberId, memberEpoch, MemberState.FATAL);
+        if (memberId.isEmpty()) {

Review Comment:
   Sorry for late review.
   
   According to the log message, it seems this condition should be `!memberId.isEmpty()`, right?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org