You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by kristopherkane <gi...@git.apache.org> on 2016/05/02 04:46:51 UTC

[GitHub] storm pull request: STORM-1701 simple JSON mapping

Github user kristopherkane commented on the pull request:

    https://github.com/apache/storm/pull/1327#issuecomment-216095877
  
    You're right.  There is no sense in replaying the same broken input.  I'm conflicted on what the right approach is to notify the topology owner of corrupt JSON or a missing row key.  I don't think it is worthy of a collector.reportError() and am wondering if it should be INFO or WARN logging. 
    
    I've got the the changes you have suggested complete minus the desired notification. How does this go with the GitHub integration?  Squash on my fork and this PR is automatically updated? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---