You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "drew-dectech (via GitHub)" <gi...@apache.org> on 2023/02/02 01:35:47 UTC
[GitHub] [fineract] drew-dectech opened a new pull request, #2945: FINERACT-1878 Update staff to read and write images to staff path
drew-dectech opened a new pull request, #2945:
URL: https://github.com/apache/fineract/pull/2945
## Description
[FINERACT-1878](https://issues.apache.org/jira/browse/FINERACT-1878) - Update path for staff images
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics closed pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics closed pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
URL: https://github.com/apache/fineract/pull/2945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] drew-dectech commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "drew-dectech (via GitHub)" <gi...@apache.org>.
drew-dectech commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1480342903
Added tests to cover the changes √
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1552239842
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1414286947
@drew-dectech Kindly asking you to run the "./gradlew spotlessApply" on the project to get rid of the checkstyle issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "galovics (via GitHub)" <gi...@apache.org>.
galovics commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1510982210
@drew-dectech I don't see the tests for the file repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1455261052
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] adamsaghy commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1580003246
@drew-dectech Are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1878 Update staff to read and write images to staff path [fineract]
Posted by "jason-waale (via GitHub)" <gi...@apache.org>.
jason-waale commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1794020567
@adamsaghy @galovics, what's the process for me to pick up ownership of finishing this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] drew-dectech commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "drew-dectech (via GitHub)" <gi...@apache.org>.
drew-dectech commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1468282949
> @drew-dectech is this still being worked on or can we close this PR as it's quite stale?
Going to get the tests in today, sorry about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2945: FINERACT-1878 Update staff to read and write images to staff path
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1467644647
@drew-dectech is this still being worked on or can we close this PR as it's quite stale?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1878 Update staff to read and write images to staff path [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #2945:
URL: https://github.com/apache/fineract/pull/2945#issuecomment-1794480663
I am not sure, but i would say hence it was 6 month since he did anything in this PR:
- you might wanna take his changes and open a new PR, but please give him credit for the changes he did
@drew-dectech Are you okay with this approach or would you like to finish this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org