You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2008/08/26 06:30:40 UTC
svn commit: r688958 - in /ant/core/trunk: WHATSNEW
src/main/org/apache/tools/ant/util/DateUtils.java
src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java
Author: bodewig
Date: Mon Aug 25 21:30:39 2008
New Revision: 688958
URL: http://svn.apache.org/viewvc?rev=688958&view=rev
Log:
Don't use a thousands separator at all for minutes. PR 44659.
Modified:
ant/core/trunk/WHATSNEW
ant/core/trunk/src/main/org/apache/tools/ant/util/DateUtils.java
ant/core/trunk/src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java
Modified: ant/core/trunk/WHATSNEW
URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=688958&r1=688957&r2=688958&view=diff
==============================================================================
--- ant/core/trunk/WHATSNEW (original)
+++ ant/core/trunk/WHATSNEW Mon Aug 25 21:30:39 2008
@@ -85,6 +85,12 @@
may not have started at all.
Bugzilla Report 45227.
+ * If the number of minutes a build takes is bigger then 1000 Ant will
+ no longer print a thousands separator in the "elapsed time"
+ message. It used to be the thousands separator of the current
+ locale.
+ Bugzilla Report 44659.
+
Fixed bugs:
-----------
Modified: ant/core/trunk/src/main/org/apache/tools/ant/util/DateUtils.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/main/org/apache/tools/ant/util/DateUtils.java?rev=688958&r1=688957&r2=688958&view=diff
==============================================================================
--- ant/core/trunk/src/main/org/apache/tools/ant/util/DateUtils.java (original)
+++ ant/core/trunk/src/main/org/apache/tools/ant/util/DateUtils.java Mon Aug 25 21:30:39 2008
@@ -73,7 +73,7 @@
private static final double[] LIMITS = {0, 1, 2};
- private static final String[] MINUTES_PART = {"", "1 minute ", "{0,number} minutes "};
+ private static final String[] MINUTES_PART = {"", "1 minute ", "{0,number,###############} minutes "};
private static final String[] SECONDS_PART = {"0 seconds", "1 second", "{1,number} seconds"};
Modified: ant/core/trunk/src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java
URL: http://svn.apache.org/viewvc/ant/core/trunk/src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java?rev=688958&r1=688957&r2=688958&view=diff
==============================================================================
--- ant/core/trunk/src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java (original)
+++ ant/core/trunk/src/tests/junit/org/apache/tools/ant/util/DateUtilsTest.java Mon Aug 25 21:30:39 2008
@@ -43,7 +43,7 @@
}
// https://issues.apache.org/bugzilla/show_bug.cgi?id=44659
- public void XtestLongElapsedTime(){
+ public void testLongElapsedTime(){
assertEquals("2926 minutes 13 seconds",
DateUtils.formatElapsedTime(1000 * 175573));
}