You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/01 08:09:39 UTC

[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #9980: [Fix-9921] Add the mechanism to increment the workerWaitingTaskCount in HeartBea…

ruanwenjun commented on code in PR #9980:
URL: https://github.com/apache/dolphinscheduler/pull/9980#discussion_r934251266


##########
dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/HeartBeatTask.java:
##########
@@ -67,6 +67,15 @@ public HeartBeatTask(long startupTime,
         this.heartBeat = new HeartBeat(startupTime, maxCpuloadAvg, reservedMemory, hostWeight, workerThreadCount);
     }
 
+    public void setWorkerWaitingTaskCount(int count){
+        this.workerWaitingTaskCount  = count;
+    }
+
+    public void incrementWorkerWaitingTaskCount(){
+        this.workerWaitingTaskCount++;

Review Comment:
   +1, this patch cannot solve this problem, you can use a Supplier to replace the workerWaitingTaskCount to solve this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org