You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Supun Kamburugamuva (JIRA)" <ji...@apache.org> on 2009/05/26 05:22:45 UTC

[jira] Created: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Allow XML elements to be specified as faule detail in FaultMediator
-------------------------------------------------------------------

                 Key: SYNAPSE-553
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
             Project: Synapse
          Issue Type: Improvement
          Components: Core
            Reporter: Supun Kamburugamuva


At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment: SYNAPSE-553.patch

Hi Andreas,

Thanks for the suggestion. I've improved the patch.

Thannks,
Supun..

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment:     (was: SYNAPSE-553.patch)

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment:     (was: SYNAPSE-553-2.patch)

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment: SYNAPSE-553.patch

I've attached a modified patch. In this patch, the fauldetail element is cloned for every request. we have to clone it every time due to the following reason.

For the first request we set the fault detail element. This will not detach the faultdetail element as it doesn't have a parent.

For the second request, when we set the detail element it will detach the fault detail element from the parent. This means first request will lost the fault detail element.

To avoid this we have to clone it every time.


> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment:     (was: SYNAPSE-553.patch)

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment: SYNAPSE-553-2.patch

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553-2.patch, SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713422#action_12713422 ] 

Supun Kamburugamuva commented on SYNAPSE-553:
---------------------------------------------

Thanks for pointing this out. I'll resubmit the patch.

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment: SYNAPSE-553.patch

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12714917#action_12714917 ] 

Andreas Veithen commented on SYNAPSE-553:
-----------------------------------------

I think that the detail element in a SOAP fault can have multiple child elements. Could you generalize the patch so that this case is also covered?

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713415#action_12713415 ] 

Ruwan Linton commented on SYNAPSE-553:
--------------------------------------

Yes, you need to clone the OMElement before attaching it to the SOAPDetail node, or may be a build at the setter level would also work...

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment:     (was: SYNAPSE-553.patch)

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712998#action_12712998 ] 

Andreas Veithen commented on SYNAPSE-553:
-----------------------------------------

Are you sure that the following line gives the expected result:

soapFaultDetail.addChild(faultDetailElement);

The reason I'm asking this is that addChild not necessarily copies the element, but may detach it from the original message and attach it to the new location. This would lead to unpredictable results when several messages are processed simultaneously.

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "indika priyantha kumara (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

indika priyantha kumara reassigned SYNAPSE-553:
-----------------------------------------------

    Assignee: indika priyantha kumara

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>            Assignee: indika priyantha kumara
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "Supun Kamburugamuva (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Supun Kamburugamuva updated SYNAPSE-553:
----------------------------------------

    Attachment: SYNAPSE-553.patch

I've attached a patch

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-553) Allow XML elements to be specified as faule detail in FaultMediator

Posted by "indika priyantha kumara (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

indika priyantha kumara resolved SYNAPSE-553.
---------------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3

apply patch for SYNAPSE-553 with a test case for test ... Thanks Supun for contributing 

> Allow XML elements to be specified as faule detail in FaultMediator
> -------------------------------------------------------------------
>
>                 Key: SYNAPSE-553
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-553
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Supun Kamburugamuva
>            Assignee: indika priyantha kumara
>             Fix For: 1.3
>
>         Attachments: SYNAPSE-553.patch
>
>
> At the moment FaultMediator doesn't allow XML elements to e specified as Fault details

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org