You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sj...@apache.org on 2026/04/11 23:19:11 UTC

(maven-script-interpreter) branch drop-log created (now e36445d)

This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a change to branch drop-log
in repository https://gitbox.apache.org/repos/asf/maven-script-interpreter.git


      at e36445d  Remove redundant diagnose logging

This branch includes the following new commits:

     new e36445d  Remove redundant diagnose logging

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



(maven-script-interpreter) 01/01: Remove redundant diagnose logging

Posted by sj...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

sjaranowski pushed a commit to branch drop-log
in repository https://gitbox.apache.org/repos/asf/maven-script-interpreter.git

commit e36445da7f54a40e55f4c4f0cc049c6f6f426b05
Author: Slawomir Jaranowski <s....@gmail.com>
AuthorDate: Sun Apr 12 01:18:47 2026 +0200

    Remove redundant diagnose logging
    
    - Caller should be responsible for logging
---
 .../apache/maven/shared/scriptinterpreter/ScriptRunner.java  | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/scriptinterpreter/ScriptRunner.java b/src/main/java/org/apache/maven/shared/scriptinterpreter/ScriptRunner.java
index 1b1773d..a1ed3e8 100644
--- a/src/main/java/org/apache/maven/shared/scriptinterpreter/ScriptRunner.java
+++ b/src/main/java/org/apache/maven/shared/scriptinterpreter/ScriptRunner.java
@@ -48,12 +48,12 @@ public class ScriptRunner implements Closeable {
      * The supported script interpreters, indexed by the lower-case file extension of their associated script files,
      * never <code>null</code>.
      */
-    private Map<String, ScriptInterpreter> scriptInterpreters;
+    private final Map<String, ScriptInterpreter> scriptInterpreters;
 
     /**
      * The common set of global variables to pass into the script interpreter, never <code>null</code>.
      */
-    private Map<String, Object> globalVariables;
+    private final Map<String, Object> globalVariables;
 
     /**
      * The file encoding of the hook scripts or <code>null</code> to use platform encoding.
@@ -149,12 +149,6 @@ public class ScriptRunner implements Closeable {
             return;
         }
 
-        LOG.info(
-                "run {} {}.{}",
-                scriptDescription,
-                relativeScriptPath,
-                FilenameUtils.getExtension(scriptFile.getAbsolutePath()));
-
         executeRun(scriptDescription, scriptFile, context, logger);
     }
 
@@ -177,8 +171,6 @@ public class ScriptRunner implements Closeable {
             return;
         }
 
-        LOG.info("run {} {}", scriptDescription, scriptFile.getAbsolutePath());
-
         executeRun(scriptDescription, scriptFile, context, logger);
     }