You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mahesh Reddy (Code Review)" <ge...@cloudera.org> on 2022/01/22 00:46:38 UTC

[kudu-CR] WIP KUDU-2671: Follow up pruning patch.

Hello Alexey Serbin, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17879

to look at the new patch set (#3).

Change subject: WIP KUDU-2671: Follow up pruning patch.
......................................................................

WIP KUDU-2671: Follow up pruning patch.

This patch modifies how partition key ranges are removed in
PartitionPruner::RemovePartitionKeyRange(). The format of the
field 'range_bounds_to_partition_key_ranges_' is also modified
so the entire set will be reverse sorted as well.

Currently, full scans with no predicates are functional.
Scans with range predicates attached produce the right result,
but the order in which the tablets are returned from the meta
cache are incorrect. They are returned by sorted order of the
hash component first, rather than the range.

The current tests don't include tables with non covering ranges.
They also don't include scans with equality predicates (only
greater or less than predicates).

Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060
---
M src/kudu/client/flex_partitioning_client-test.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/scan_token-test.cc
M src/kudu/client/scanner-internal.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/partition_pruner.h
7 files changed, 282 insertions(+), 50 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/17879/3
-- 
To view, visit http://gerrit.cloudera.org:8080/17879
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3a1bf5344c0ef856072d3ed102714dce5ba21060
Gerrit-Change-Number: 17879
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>