You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Michael Osipov (JIRA)" <ji...@apache.org> on 2015/11/26 16:16:11 UTC

[jira] [Commented] (JXPATH-186) JXPath catches Throwable

    [ https://issues.apache.org/jira/browse/JXPATH-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028975#comment-15028975 ] 

Michael Osipov commented on JXPATH-186:
---------------------------------------

I fully agree. We should never catch {{Throwable}} but {{Exception}} only.

> JXPath catches Throwable
> ------------------------
>
>                 Key: JXPATH-186
>                 URL: https://issues.apache.org/jira/browse/JXPATH-186
>             Project: Commons JXPath
>          Issue Type: Bug
>            Reporter: Michele Vivoda
>            Priority: Minor
>
> JXPath catches Throwable in 12 places, it could be a bad practice http://stackoverflow.com/a/16027430/1536382
> In most places it just rethrows but in a couple also does some logic, like in PropertyIterator where returns a NullPropertyPointer object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)